Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor operator to make use of the fdb-kubernetes-monitor API #2075

Merged

Conversation

johscheuer
Copy link
Member

Description

Refactoring for making use of the moved constants and structs here: apple/foundationdb#11464

Type of change

Please select one of the options below.

  • New feature (non-breaking change which adds functionality)

Discussion

I put this as draft until the PR above is merged.

Testing

Ran unit tests and e2e tests.

Documentation

Follow-up

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: c0b2117
  • Duration 2:51:25
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer marked this pull request as ready for review June 24, 2024 15:02
Copy link
Member Author

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fdb-kubernetes-monitor side is merged.

go.mod Outdated Show resolved Hide resolved
@johscheuer johscheuer force-pushed the operator-refactor-for-monitor-api branch from c0b2117 to 6210bd1 Compare June 24, 2024 15:19
Copy link
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

controllers/update_pod_config.go Show resolved Hide resolved
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 6210bd1
  • Duration 2:40:06
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer
Copy link
Member Author

Same failure as in the other ones:

• [FAILED] [413.512 seconds]
Operator when a Pod is unscheduled and another Pod is being replaced [It] should remove the targeted Pod [e2e, pr]
/codebuild/output/src447645687/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator/operator_test.go:583

  [FAILED] Timed out after 300.001s.
  Expected
      <bool>: false
  to be true
  In [It] at: /codebuild/output/src447645687/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/fixtures/fdb_cluster.go:1222 @ 06/24/24 15:56:02.662
------------------------------

@johscheuer johscheuer merged commit 5811779 into FoundationDB:main Jun 25, 2024
7 of 8 checks passed
@johscheuer johscheuer deleted the operator-refactor-for-monitor-api branch June 25, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants