Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run the change coordinator command before excluding the coordinator #2083

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Run the change coordinator command before excluding the coordinator #2083

merged 2 commits into from
Jul 3, 2024

Conversation

johscheuer
Copy link
Member

Description

Fixes: #2018

Type of change

Please select one of the options below.

  • New feature (non-breaking change which adds functionality)

Discussion

Testing

Updated the unit tests.

Documentation

Follow-up

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 6b7d1b6
  • Duration 4:07:30
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer force-pushed the exclude-and-change-coordinators-at-once branch from 6b7d1b6 to fa5d7b4 Compare June 27, 2024 07:36
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: fa5d7b4
  • Duration 2:45:26
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer closed this Jun 27, 2024
@johscheuer johscheuer reopened this Jun 27, 2024
@johscheuer johscheuer marked this pull request as ready for review June 27, 2024 13:59
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: fa5d7b4
  • Duration 3:09:13
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

nicmorales9
nicmorales9 reviewed Jun 28, 2024
View reviewed changes
controllers/exclude_processes.go Show resolved Hide resolved
controllers/exclude_processes_test.go Outdated Show resolved Hide resolved
internal/test_helper.go Outdated Show resolved Hide resolved
controllers/change_coordinators_test.go Outdated Show resolved Hide resolved
internal/coordinator/coordinator_test.go Outdated Show resolved Hide resolved
internal/test_helper.go Show resolved Hide resolved
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: ba5701c
  • Duration 2:55:28
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

nicmorales9
nicmorales9 approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johscheuer johscheuer merged commit 21ec9c2 into FoundationDB:main Jul 3, 2024
8 checks passed
@johscheuer johscheuer deleted the exclude-and-change-coordinators-at-once branch July 3, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicmorales9 nicmorales9 nicmorales9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider doing exclusion and coordinator change at once
3 participants
@johscheuer @foundationdb-ci @nicmorales9