-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to get the running version based on the reachable coordinators during an upgrade #2098
Try to get the running version based on the reachable coordinators during an upgrade #2098
Conversation
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems legit but I want to make sure I understand things first
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
https://github.com/FoundationDB/fdb-kubernetes-operator/blob/main/e2e/test_operator_upgrades/operator_upgrades_test.go#L557-L569 is where the failure happened, unrelated to the PR changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything looks right in theory but I still am confused 😆
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense now, thanks for sticking with me! I think it would be good to improve the comments as per the one remaining comment but otherwise LGTM
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Description
We sometimes see that the test case
Operator HA Upgrades when no remote storage processes are restarted
fails where the coordinators are reporting in the new upgraded version but the cluster is stuck with the following message:The idea for this change is to get the running version based on the reachable coordinators. If a quorum of coordinators can be reached with a specific
fdbcli
version the operator will assume that the cluster is running in that version. Doing that will unblock the operator and will allow the operator to move forward. If the running version is not updated to the new desired version the reconcilercheckClientCompatibility
will block (as the operator is not able to check for incompatible clients).Type of change
Discussion
Testing
Will be running multiple e2e tests for this change.
Documentation
Must be updated.
Follow-up