Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve team tracker checks when DD was restarted #2100

Merged

Conversation

johscheuer
Copy link
Member

Description

See comments in code.

Type of change

Please select one of the options below.

  • Bug fix (non-breaking change which fixes an issue)

Discussion

Testing

Ran unit tests and CI will run e2e tests.

Documentation

Follow-up

@johscheuer johscheuer added the bug Something isn't working label Jul 10, 2024
Copy link
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming initializing guarantees that it will come up healthy

@johscheuer
Copy link
Member Author

LGTM assuming initializing guarantees that it will come up healthy

Not necessarily, at this moment the state is unknown. But if a failure would be detected after the DD was started, it would result in the according team tracker to be updated and the Eventually statement would fail (if the replicas fall below the expected threshold).

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 1f86d5b
  • Duration 2:45:23
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer merged commit 833ec65 into FoundationDB:main Jul 10, 2024
8 checks passed
@johscheuer johscheuer deleted the e2e-test-team-tracker-check branch July 10, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants