Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move well-known env vars and config map keys into constants #2101

Merged
merged 6 commits into from
Jul 15, 2024
Merged

Move well-known env vars and config map keys into constants #2101

merged 6 commits into from
Jul 15, 2024

Conversation

nicmorales9
Copy link
Contributor

Description

fixes #1412 and #2029

I did my best to add meaningful comment descriptions, almost entirely lifted from descriptions elsewhere in the operator or in the FoundationDB repo itself - would be great to check those over

Type of change

Please select one of the options below.

  • Other (code tidying)

Discussion

Are there any design details that you would like to discuss further?
No

Testing

Please describe the tests that you ran to verify your changes. Unit tests?
Manual testing?
I ran the unit tests

Do we need to perform additional testing once this is merged, or perform in a larger testing environment?
No

Documentation

N/A

Follow-up

N/A

@nicmorales9
Move ConfigMap known keys into constants FoundationDB#1412
38ad5d3 
fixes FoundationDB#1412
also starts adding env var constants
@nicmorales9
swap env var strings to constants
c93dca8 
minus one big test file which has inline changes and is hard to read so separating commit
@nicmorales9
test with sprintf constant substitutions
79931bc
@nicmorales9 nicmorales9 changed the title Move known env vars and config map keys into constants Move well-known env vars and config map keys into constants Jul 11, 2024
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 79931bc
  • Duration 2:29:59
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@nicmorales9
submit to the linter
2589c8d 
s/Id/ID
typo in comment
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 2589c8d
  • Duration 2:56:21
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

johscheuer
johscheuer reviewed Jul 15, 2024
View reviewed changes
Copy link
Member

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, otherwise 👍

api/v1beta1/foundationdbcluster_types_test.go Show resolved Hide resolved
api/v1beta2/foundationdb_constants.go Outdated Show resolved Hide resolved
api/v1beta2/foundationdb_env_variables.go Outdated Show resolved Hide resolved
api/v1beta2/foundationdb_env_variables.go Outdated Show resolved Hide resolved
api/v1beta2/foundationdb_env_variables.go Outdated Show resolved Hide resolved
api/v1beta2/foundationdb_env_variables.go Outdated Show resolved Hide resolved
api/v1beta2/foundationdb_env_variables.go Outdated Show resolved Hide resolved
api/v1beta2/foundationdb_env_variables.go Outdated Show resolved Hide resolved
api/v1beta2/foundationdb_env_variables.go Outdated Show resolved Hide resolved
e2e/fixtures/fdb_cluster_specs.go Show resolved Hide resolved
nicmorales9 and others added 2 commits July 15, 2024 11:09
@nicmorales9 @johscheuer
Apply suggestions from code review
e756f4b 
Co-authored-by: Johannes Scheuermann <johscheuer@users.noreply.github.com>
@nicmorales9
review catches
da723d4
johscheuer
johscheuer approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!

api/v1beta1/foundationdbcluster_types_test.go Show resolved Hide resolved
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: e756f4b
  • Duration 2:44:48
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: da723d4
  • Duration 2:51:20
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@nicmorales9 nicmorales9 merged commit 8c91d78 into FoundationDB:main Jul 15, 2024
7 of 8 checks passed
@nicmorales9
Copy link
Contributor Author

failures unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johscheuer johscheuer johscheuer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move ConfigMap known keys into constants
3 participants
@nicmorales9 @foundationdb-ci @johscheuer