Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #803

Merged
merged 4 commits into from
Jul 1, 2021
Merged

Fix CI #803

merged 4 commits into from
Jul 1, 2021

Conversation

johscheuer
Copy link
Member

@johscheuer johscheuer commented Jul 1, 2021

Description

Fixes: #802

Please include a summary of the change and which issue is addressed. If this change resolves an issue, please include the issue number in the description.

Type of change

Please select one of the options below.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation
  • Other

Discussion

Are there any design details that you would like to discuss further?

Testing

Please describe the tests that you ran to verify your changes. Unit tests?
Manual testing?

Do we need to perform additional testing once this is merged, or perform in a larger testing environment?

Documentation

Did you update relevant documentation within this repository?

If this change is adding new functionality, do we need to describe it in our user manual?

If this change is adding or removing subreconcilers, have we updated the core technical design doc to reflect that?

If this change is adding new safety checks or new potential failure modes, have we documented and how to debug potential issues?

Follow-up

Are there any follow-up issues that we should pursue in the future?

Does this introduce new defaults that we should re-evaluate in the future?

@johscheuer johscheuer added the bug Something isn't working label Jul 1, 2021
@johscheuer johscheuer requested a review from 09harsh July 1, 2021 09:56
@johscheuer johscheuer marked this pull request as ready for review July 1, 2021 09:56
@johscheuer
Copy link
Member Author

Fixed and related to helm/kind-action#42 the fix was to upgrade to 0.11.1 (kind)

@@ -29,16 +29,3 @@ EOF
# connect the registry to the cluster network
# (the network may already be connected)
docker network connect "kind" "${reg_name}" || true

# Document the local registry
cat <<EOF | kubectl apply -f -
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually don't need this

kubever: [ "v1.17.0", "v1.18.0", "v1.19.0", "v1.20.0" ]
# See https://kubernetes.io/releases for the current releases
kubever: [ "v1.19.0", "v1.20.0", "v1.21.1" ]
fdbver: ["6.2.30", "6.3.15"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to test at least these version (we could also test 6.1 but I think 6.2 and 6.3 is fine.

@johscheuer johscheuer changed the title Debug ci Fix CI Jul 1, 2021
Copy link
Contributor

@09harsh 09harsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

@09harsh 09harsh merged commit f6e66d9 into FoundationDB:master Jul 1, 2021
@johscheuer johscheuer deleted the debug-ci branch July 1, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI is currently broken
2 participants