Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New the representation of aggregate plans #2763

Open
hatyo opened this issue Jun 14, 2024 · 0 comments
Open

New the representation of aggregate plans #2763

hatyo opened this issue Jun 14, 2024 · 0 comments
Assignees
Labels
planner Related to the query planner

Comments

@hatyo
Copy link
Contributor

hatyo commented Jun 14, 2024

This proposes a new representation of aggregate plans that gets rid of the first grouping Value in the underlying select expression.

Doing so would achieve two goals:

  • Avoid ambiguous derivation of fields: currently, a grouping field exists twice, once in the grouping value RCV, and another time in the quantifier of the originating table. This is unnecessary and makes integration of the value mapping API more complex.
  • Overall simplification in the plan generation logic: maintaining the grouping Value is complex and requires some state that increases the complexity of the plan generator. Getting rid of the grouping Value would help streamlining the logic of the plan generator.
@hatyo hatyo added the planner Related to the query planner label Jun 14, 2024
@hatyo hatyo self-assigned this Jun 14, 2024
alecgrieser pushed a commit that referenced this issue Jul 8, 2024
This proposes a new representation of aggregate plans that gets rid of the first grouping Value in the underlying select expression, and consumes @normen662's fix for an issue with Value simplification engine not being to handle QOV correctly when pulling up a Value.

It addresses #2763 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
planner Related to the query planner
Projects
None yet
Development

No branches or pull requests

1 participant