Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to use NGROK_SUBDOMAIN for /slack/add handler? #1

Closed
alexagranov opened this issue May 15, 2018 · 3 comments
Closed

Need to use NGROK_SUBDOMAIN for /slack/add handler? #1

alexagranov opened this issue May 15, 2018 · 3 comments

Comments

@alexagranov
Copy link
Contributor

First of all, thank you so much for creating Walkie - it's been indispensable. And thank you x10 for open sourcing it to live on and maybe even grow.

Trying to get a local instance up and running before the end of the month and hitting an obstacle getting the Slack login working.

I wonder if this line should actually be using the NGROK_SUBDOMAIN env var:
https://github.com/FoundersAS/walkiebot/blob/master/server/handlers/slack.js#L36

@freeall
Copy link

freeall commented May 15, 2018

@alexagranov I think you are right about that. Can you try to change the line and see if it can work for you? Either make a PR or just let me know, and I'll update it.

@alexagranov
Copy link
Contributor Author

alexagranov commented May 15, 2018 via email

@alexagranov
Copy link
Contributor Author

PR #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants