Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static content URLs not right in Heroku deployment #4

Closed
guillegette opened this issue May 15, 2018 · 2 comments
Closed

Static content URLs not right in Heroku deployment #4

guillegette opened this issue May 15, 2018 · 2 comments

Comments

@guillegette
Copy link

Hi team,

First of all, what an awesome tool. Sad to see you guys take this down but totally understandable. I went ahead and run the deployment in Heroku and everything went well but once you visit the app URL I can see that 2 JS files don't have the right path.

image

Any ideas?
Deployment URL: https://workast-walkiebot.herokuapp.com/

@alexagranov
Copy link
Contributor

alexagranov commented May 15, 2018

So I noticed this as well, even just trying yarn start locally to serve the server/index.js file.

Then I took another look at the Quick Start and that is referring to yarn dev which actually runs bin/start-dev.sh to start a few processes locally - one of them is actually booting webpack-dev server via devserver.js (on 8005) while nodemon is used to kick up another server on 8000 to service the endpoints (proxied to from devserver.js). I opened a ticket/PR to get some clarification if possible in #2.

Basically, I don't think server/index.js is ever used to serve static files, only dev-index.ejs is used for that (I think).

@dinoshauer
Copy link
Contributor

Hiya! Just fixed this in 9aa5d6c - You may have to do a redeploy on heroku or recreate the app, not sure how that works with heroku. In any case it's probably worth forking this repo after creating the heroku app and setting it up to track your own fork so you can deploy it directly from git :)

@alexagranov the catchAll and dist handlers are used to serve some of that content, specifically https://github.com/FoundersAS/walkiebot/blob/master/server/handlers/resources.js is used to serve all static files :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants