Implementation of console logging & Project Restructure #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Founntain
added
documentation
… logging # Conflicts: # OsuPlayer.Data/DataModels/DbMapEntryBase.cs # OsuPlayer.Data/DataModels/IDbReaderFactory.cs # OsuPlayer.IO/DbReader/OsuDbReader.cs # OsuPlayer.IO/DbReader/RealmReader.cs # OsuPlayer.Interfaces/OsuPlayer.Interfaces.csproj # OsuPlayer.Services/OsuPlayer.Services.csproj
…ng these in the service
|
This PR also includes a huge overhaul of the project structure. The key problem was, that it wasn't possible to call services in a variety of projects. Mostly IO or Network. This was and would be a big hindrance in the future, as for example it wouldn't be possible to call the LoggingService in IO or Network. This is now possible as @Cesan and I restructured the project. There is a new Interface project that helps us telling other projects what service exist and what they can do. Which in the end gives us the ability to call these services in the IO or Network project. The reference Hierarchy was as followed: Now it is as followed: |
Founntain
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a basic logging service, that provides us with the ability to log to the console. Also every service now prints it's status when de-/initializing.
OsuSongSourceProvider=>OsuSongSourceService