fix: hang on read-only filesystems #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix! |
FoxxMD
added a commit
that referenced
this pull request
Sep 11, 2024
* Simplify the logic for testing if a file or parent directories are writeable * Add a test suite to verify file/dir access testing works as expected #2
|
@jackwilsdon can you try out |
|
I'm using |
|
I've updated multi-scrobbler to use the fixed version. You should be able to pull |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux systems where the log directory and all of its parents are not writable,
fileOrDirectoryIsWriteablecurrently spins forever withcurrPath.direqual to/.