feat(docker)!: Use debian image as default

Sporadic DNS issues with alpine have caused a number of issues #160 #126 #134

Use debian as default since it has been proven to be stable. The image size increase is worth squashing these issues.

.dockerignore

@@ -2,6 +2,7 @@
 node_modules
 npm-debug.log
 Dockerfile
+*.Dockerfile
 .dockerignore
 .gitignore
 .github

.github/workflows/pr.yml

@@ -45,8 +45,8 @@ jobs:
           - dockerfile: ./Dockerfile
             suffix: ''
             platforms: 'linux/amd64,linux/arm64'
-          - dockerfile: ./debian.Dockerfile
-            suffix: '-debian'
+          - dockerfile: ./alpine.Dockerfile
+            suffix: '-alpine'
             platforms: 'linux/amd64,linux/arm64'
     steps:
       - name: Set up QEMU
@@ -91,12 +91,13 @@ jobs:
           APP_VERSION: ${{ format('pr{0}-{1}', github.event.number, github.event.pull_request.head.sha ) }}
         with:
           context: .
-          push: true
+          build-args: |
+            APP_BUILD_VERSION=${{env.APP_VERSION}}
           file: ${{ matrix.dockerfile }}
+          push: ${{ !env.ACT}}
           tags: ${{ steps.meta.outputs.tags }}
+          labels: ${{ steps.meta.outputs.labels }}
           platforms: ${{ matrix.platforms }}
-          build-args: |
-            APP_BUILD_VERSION=${{env.APP_VERSION}}
 
   combine-and-comment:
     name: Leave comment
@@ -114,7 +115,7 @@ jobs:
 
             To play around with this PR, pull an image:
             * `foxxmd/multi-scrobbler:pr-${{ github.event.number }}`
-            * `foxxmd/multi-scrobbler:pr-${{ github.event.number }}-debian`.
+            * `foxxmd/multi-scrobbler:pr-${{ github.event.number }}-alpine`.
 
             Images are available for x86_64 and ARM64.
 

.github/workflows/publishImage.yml

@@ -50,8 +50,8 @@ jobs:
           - dockerfile: ./Dockerfile
             suffix: ''
             platforms: 'linux/amd64,linux/arm64'
-          - dockerfile: ./debian.Dockerfile
-            suffix: '-debian'
+          - dockerfile: ./alpine.Dockerfile
+            suffix: '-alpine'
             platforms: 'linux/amd64,linux/arm64'
     # https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token
     permissions:

docsite/docs/FAQ.md

@@ -4,7 +4,6 @@
   * [Jellyfin has warnings about undefined or missing data](#jellyfin-has-warnings-about-undefined-or-missing-data)
   * [Jellyfin has warnings about missing headers](#jellyfin-has-warnings-about-missing-headers)
   * [Spotify/Deezer/LastFM won't authenticate](#spotifydeezerlastfm-wont-authenticate)
-  * [Sporadic network problems on docker](#sporadic-network-problems-on-docker)
 * [Configuration Issues](#configuration-issues)
   * [Config could not be parsed](#config-could-not-be-parsed)
 * [Scrobbling Issues](#scrobbling-issues)
@@ -131,16 +130,6 @@ If multi-scrobbler is not running on the same machine your browser is on then th
 
 EX `http://localhost:9078/lastfm/callback` -> `http://192.168.0.220:9078/lastfm/callback`
 
-## Sporadic network problems on docker
-
-If you encounter networking issues like:
-
-* sporadic timeouts (`ETIMEDOUT`) without a pattern
-* DNS errors (`EAI_AGAIN`) that do no occur consistently
-* Failures to reach a host that was previously fine (`EHOSTUNREACH`)
-
-there may be an issue with the underlying docker image OS (alpine) that may be solved by switching to a different image. Try switching to a `*-debian` variant tag (only available for ARM hosts) to see if this resolves your issue. IE `multi-scrobbler:latest-debian` or `multi-scrobbler:develop-debian`
-
 # Configuration Issues
 
 ## Config could not be parsed

docsite/docs/installation/installation.md

@@ -156,16 +156,6 @@ To get the UID and GID for the current user run these commands from a terminal:
 * `id -u` -- prints UID
 * `id -g` -- prints GID
 
-### Network Issues
-
-If you encounter networking issues like:
-
-* sporadic timeouts (`ETIMEDOUT`) without a pattern
-* DNS errors (`EAI_AGAIN`) that do no occur consistently
-* Failures to reach a host that was previously fine (`EHOSTUNREACH`)
-
-there may be an issue with the underlying docker image OS (alpine) that may be solved by switching to a different image. Try switching to a `*-debian` variant tag (only available for x86/x64 hosts) to see if this resolves your issue. IE `multi-scrobbler:latest-debian` or `multi-scrobbler:develop-debian`
-
 ## Docker Usage Examples
 
 If installing on a different machine make sure all redirect URIs are defined or that you have set a [Base URL](#base-url).