Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error scrobbling songs by Daft Punk from LB to Maloja #94

Closed
ghost opened this issue Sep 12, 2023 · 3 comments
Closed

Error scrobbling songs by Daft Punk from LB to Maloja #94

ghost opened this issue Sep 12, 2023 · 3 comments

Comments

@ghost
Copy link

ghost commented Sep 12, 2023

Using version 0.5.1 of the develop branch (Nodejs). Using version 3.1.5 of maloja.

Listening to any song by Daft Punk results in the artist being scrobbled as multiple artists Daft Punk, Da, and Punk.

For example, listening to the song Instant Crush by Daft Punk and Julian Casablancas.

 {
  "track_metadata": {
    "track_name": "Instant Crush (feat. Julian Casablancas)",
    "artist_name": "Daft Punk",
    "release_name": "Random Access Memories",
    "additional_info": {
      "duration": 338,
      "origin_url": "https://music.youtube.com/watch?v=khnokW3Mw24",
      "submission_client": "Web Scrobbler",
      "music_service_name": "YouTube Music",
      "submission_client_version": "3.1.0",
      "recording_msid": "878c787e-5dd4-42b4-9c2b-1b53baec7e8b"
    },
    "mbid_mapping": {
      "recording_mbid": "dbc0da50-4bc6-4230-9e7b-136b5dc2b31a",
      "recording_name": "Instant Crush",
      "release_mbid": "bbfc83ad-826f-4957-893d-a808105c828b",
      "artists": [
        {
          "artist_mbid": "056e4f3e-d505-4dad-8ec1-d04f521cbb56",
          "artist_credit_name": "Daft Punk",
          "join_phrase": " feat. "
        },
        {
          "artist_mbid": "c5ce487b-0462-444e-a184-4de0fef7e028",
          "artist_credit_name": "Julian Casablancas",
          "join_phrase": ""
        }
      ],
      "artist_mbids": [
        "056e4f3e-d505-4dad-8ec1-d04f521cbb56",
        "c5ce487b-0462-444e-a184-4de0fef7e028"
      ],
      "caa_id": 32554171842,
      "caa_release_mbid": "5000a285-b67e-4cfc-b54b-2b98f1810d2e"
    }
  },
  "listened_at": 1694479888,
  "recording_msid": "878c787e-5dd4-42b4-9c2b-1b53baec7e8b",
  "user_name": "kinescou",
  "inserted_at": 1694480058
}
2023-09-11T20:55:10-04:00 debug : [Scrobblers] [Maloja - Maloja] Raw Payload: {"album":"Random Access Memories","artists":["Daft Punk","Da","Punk","Julian Casablancas"],"key":"key","length":338,"time":1694479888,"title":"Instant Crush"}
2023-09-11T20:55:10-04:00 info : [Scrobblers] [Maloja - Maloja] Scrobbled (Backlog) => (listenbrainz) Daft Punk / Da / Punk / Julian Casablancas - Instant Crush @ 2023-09-11T20:51:28-04:00`

This happens with every song by Daft Punk across a variety of sources (desktop music player, Web Scrobbler, Pano Scrobbler).

It might be that it's seeing the ft in the artist's name as an artist separator instead of as part of their name.

FoxxMD added a commit that referenced this issue Sep 12, 2023
…word character

Prevents artists with joiner phrases in their name (EX 'Daft Punk' contains 'ft') from erroneously being split

Fixes #94
@FoxxMD
Copy link
Owner

FoxxMD commented Sep 12, 2023

Thanks for the detailed writeup and listenbrainz data! That made it super easy to reproduce and fix this.

This should be fixed in the develop branch now.

@ghost
Copy link
Author

ghost commented Sep 13, 2023

Thank you, works great!

@ghost ghost closed this as completed Sep 13, 2023
@FoxxMD
Copy link
Owner

FoxxMD commented Sep 13, 2023

This is now available in the latest docker image, master git branch, and 0.5.2 docker image/git tag.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant