Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jellyfin): Enforcing media type and session handling fixes #210

Merged
merged 11 commits into from
Oct 15, 2024
Merged

fix(jellyfin): Enforcing media type and session handling fixes #210

merged 11 commits into from
Oct 15, 2024

Conversation

FoxxMD
Copy link
Owner

@FoxxMD FoxxMD commented Oct 14, 2024

Checklist before requesting a review

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Describe your changes

  • Enforce media type for valid sessions
  • Log platform for easier debugging
  • Enable json output for first-time seen media data using logPayload

Issue number and link, if applicable

#209

@FoxxMD FoxxMD added bug Something isn't working safe to test trusted to build image labels Oct 14, 2024
@FoxxMD FoxxMD self-assigned this Oct 14, 2024
@FoxxMD FoxxMD mentioned this pull request Oct 14, 2024
Closed
2 tasks
@FoxxMD
Copy link
Owner Author

FoxxMD commented Oct 15, 2024

For my future self:

  • theme songs have same MediaType and Type as regular tracks (Audio) so they require descriminating by ExtraType to ignore
  • Audio books may have Type: Book so proactively ignoring that
  • Ideally...we would do an item lookup the first time we see an Id and check to see what libraries an Item is included in, then check to see if those libraries have Audio type but...
    • Unclear if its possible to even get individual library info and determine their type using the API
    • Doesn't seem possible to filter items by library or get item only from a specific library using the API

FoxxMD added 3 commits October 15, 2024 17:39
@FoxxMD
docs: Enable parsing json5 for AIO examples
ffd74ae
@FoxxMD
feat(jellyfin): Support and enforce library collection type
3e55764 
* Default disallow any activity not from a library of collectionType 'music'
* Allow user config for allow/block by library name
* Allow user config for allowing additional library collection types
* Update docs and example config
@FoxxMD
chore(vscode): Add markdown extension to devcontainer
dee8d6b
@github-actions GitHub Actions
Copy link
Contributor

📦 A new release has been made for this pull request.

To play around with this PR, pull an image:

  • foxxmd/multi-scrobbler:pr-210

Images are available for x86_64 and ARM64.

Latest commit: dee8d6b

@FoxxMD FoxxMD merged commit b2efc34 into master Oct 15, 2024
4 checks passed
@FoxxMD FoxxMD deleted the GH-209/jellyfinCleanup branch October 15, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@FoxxMD FoxxMD

Labels
bug Something isn't working safe to test trusted to build image
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@FoxxMD