Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nested JSON MotD issue (Ruby) #226

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Fix nested JSON MotD issue (Ruby) #226

merged 2 commits into from
Apr 1, 2024

Conversation

ldilley
Copy link
Member

@ldilley ldilley commented Mar 31, 2024

Proposed Changes

@ldilley ldilley added bug Something isn't working lang: Ruby Affects the Ruby version of minestat labels Mar 31, 2024
@ldilley ldilley requested a review from mindsolve March 31, 2024 01:06
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@AppVeyorBot
Copy link

✅ Build minestat 1.0.0.439 completed (commit e520e78a02 by @ldilley)

@ldilley ldilley mentioned this pull request Mar 31, 2024
Closed
ryush00
ryush00 approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@ryush00 ryush00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Also I tested several servers that using nested MotD and it works perfect!

@ldilley ldilley merged commit 54e9a1c into FragLand:master Apr 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryush00 ryush00 ryush00 approved these changes

@mindsolve mindsolve Awaiting requested review from mindsolve

Assignees

@ldilley ldilley

@mindsolve mindsolve

Labels
bug Something isn't working lang: Ruby Affects the Ruby version of minestat
Projects
MineStat
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ldilley @AppVeyorBot @ryush00 @mindsolve