Feature/negative durations #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 24, 2018 13:37
| @@ -56,6 +59,14 @@ | |||
| </tr> | |||
|
|
|||
| <tr> | |||
| <td *ngIf="config.showNegative"> | |||
| <input type="checkbox" id="dp-negative" [(ngModel)]="negative" #status [disabled]="disabled"> | |||
There was a problem hiding this comment.
why do we need this <input> ?
| @@ -59,11 +59,47 @@ describe('DurationPickerComponent', () => { | |||
| expect(component.generate()).toBe('P9MT10M'); | |||
| }); | |||
|
|
|||
| it('generate() should correctly generate the negative duration values', () => { | |||
There was a problem hiding this comment.
this test is failing for me
|
@DerHahne Thanks a lot for your contribution! Please check my review comments |
added 2 commits
May 28, 2018 09:03
|
Hi! We have a binding on a variable by clicking the negative/positive state button without input checkbox. For the failing unit test i forgot to add a variable which must be set to true. |
|
@DerHahne merged, thanks a lot! |
|
Thx @ShinDarth !!! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I implemented the feature request to enable negative time durations. The configuration is set to false by default.
This implementation is regarding to feature request #3