[0.5.x] Detect qt5ct and workaround it #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, I'll look into merge it. |
Use native python functionality rather than from a third-party library. The documentation of python's `os` module recommends modifying `os.environ` directly, rather than using `os.unsetenv()`. (Modifying the former causes the latter to be called; using the latter doesn't update the former.)
|
Knew I was overlooking something... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Written in response to the recent various "icons not being drawn" comments.)
qt5ctcreates (or requires the user to create) the environment argumentQT_QPA_PLATFORMTHEMEwith the valueqt5ct.The code supplied below detects the existence of the environment argument, checks its value, and if relevant adds a (blank) argument to be passed to the invocation of
QApplication. This appears to causes Qt to ignore the environment value and fallback on the default platform theme.A fix doesn't seem to be needed for the
0.6/developbranch.