Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also serializing the full name of a Node as name in Neo4J #1063

Merged
merged 4 commits into from
Feb 1, 2023
Merged

Also serializing the full name of a Node as name in Neo4J #1063

merged 4 commits into from
Feb 1, 2023

Conversation

oxisto
Copy link
Member

@oxisto oxisto commented Jan 25, 2023 •
edited
Loading

This adds the name property back into Neo4J. It contains the fullName (aka toString()) representation of a Name.

@oxisto oxisto marked this pull request as ready for review February 1, 2023 07:38
@oxisto oxisto requested a review from konradweiss as a code owner February 1, 2023 07:38
@oxisto oxisto requested a review from peckto February 1, 2023 07:58
konradweiss
konradweiss approved these changes Feb 1, 2023
View reviewed changes
Copy link
Collaborator

@konradweiss konradweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider where we add the aliasing information name fullName, the rest is fine IMO

cpg-core/src/main/java/de/fraunhofer/aisec/cpg/helpers/NameConverter.kt Show resolved Hide resolved
@oxisto oxisto enabled auto-merge (squash) February 1, 2023 11:38
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@oxisto oxisto merged commit 6833080 into main Feb 1, 2023
@oxisto oxisto deleted the neo4j-name branch February 1, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradweiss konradweiss konradweiss approved these changes

@peckto peckto Awaiting requested review from peckto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oxisto @konradweiss