Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overload operator-> for CallExpression #1842

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Conversation

peckto
Copy link
Collaborator

@peckto peckto commented Nov 14, 2024

No description provided.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.14%. Comparing base (66aa2da) to head (0930e00).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...n/de/fraunhofer/aisec/cpg/passes/SymbolResolver.kt 73.33% 1 Missing and 3 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...n/de/fraunhofer/aisec/cpg/passes/SymbolResolver.kt 88.21% <73.33%> (+0.47%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@peckto
Copy link
Collaborator Author

peckto commented Nov 14, 2024

Can someone explain to me, why the codecov/patch QA fails? I don't get it.

@oxisto
Copy link
Member

oxisto commented Nov 16, 2024

Can someone explain to me, why the codecov/patch QA fails? I don't get it.

It is probably failing because you are not reaching all branch targets in the line (yellow).

@peckto peckto force-pushed the fix-overload-reference branch from fe1ce47 to 4591828 Compare November 19, 2024 20:13
@peckto
Copy link
Collaborator Author

peckto commented Nov 19, 2024

Can someone explain to me, why the codecov/patch QA fails? I don't get it.

It is probably failing because you are not reaching all branch targets in the line (yellow).

The red one seems to be gone now. Dont know about the yellow one, but it does not block the CI ^^

@peckto peckto force-pushed the fix-overload-reference branch 2 times, most recently from c031625 to aa81616 Compare November 20, 2024 20:19
@peckto peckto force-pushed the fix-overload-reference branch from aa81616 to 0930e00 Compare November 20, 2024 21:47
@oxisto oxisto merged commit 90a1534 into main Nov 20, 2024
3 of 4 checks passed
@oxisto oxisto deleted the fix-overload-reference branch November 20, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants