Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EOG: when instead of custom dispatcher #1849

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Conversation

konradweiss
Copy link
Collaborator

Improves debugability by using when instead of custom handling map and dispatching function. Users have to order the when options such that more specific is check does not get shadowed by the more general check for its super class. However, modern IDEs can warn of such "unrechable" cases

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 98.11321% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.08%. Comparing base (c98539c) to head (9b7c9d9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...hofer/aisec/cpg/passes/EvaluationOrderGraphPass.kt 98.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...hofer/aisec/cpg/passes/EvaluationOrderGraphPass.kt 88.46% <98.11%> (-1.08%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@oxisto oxisto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except a minor thing

@konradweiss konradweiss merged commit afad877 into main Nov 18, 2024
4 checks passed
@konradweiss konradweiss deleted the kw/handleToWhenDebuggability branch November 18, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants