Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transport): Handle socket close error during reconnect #414

Merged
merged 1 commit into from
Jul 14, 2023
Merged

fix(transport): Handle socket close error during reconnect #414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/gallia/transports/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,10 @@ async def reconnect(self: TransportT, timeout: float | None = None) -> Transport
obsolete. This method is safe for concurrent use.
"""
async with self.mutex:
await self.close()
try:
await self.close()
except ConnectionError as e:
self.logger.debug(f"Socket close failed during reconnect ({e}); ignore")
return await self.connect(self.target)

@abstractmethod
Expand Down