Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup / Performance improvement #25

Merged
merged 19 commits into from
Apr 13, 2023

Conversation

carlos-schmidt
Copy link
Collaborator

@carlos-schmidt carlos-schmidt commented Mar 31, 2023

  • Client: Reuse contractAgreements when available
    • Don't need to negotiate another agreement when a valid agreement exists
  • Move synchronization logic out of endpoint class
    • SRP
  • Clean up configuration class
  • Hide self description repository behind a class
    • Also make it an observable
  • Add missing license headers
  • Improve testing code coverage
    • Add ClientEndpointTest.java

@carlos-schmidt carlos-schmidt marked this pull request as ready for review April 6, 2023 09:00
@carlos-schmidt carlos-schmidt merged commit 1d64e85 into FraunhoferIOSB:main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant