Fix folder permissions in docker for openshift deployment #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks for the PR! |
|
We noticed an issue with tomcat not being able to write to the webapps directory: If it can't unzip the war file, Liquibase doesn't work... This was reproduceable when using the docker-compose-separated.yaml setup. I've made a branch (https://github.com/FraunhoferIOSB/FROST-Server/tree/fixes-userRights) that unzips the war file when creating the Docker image. This seems to work for the docker-compose setup. Can you test if it still works in OpenShift? |
phertweck
added a commit
that referenced
this pull request
Jul 1, 2020
|
@hylkevds Sorry for the late reply! Your change is running on openshift just fine 👌 |
hylkevds
added a commit
that referenced
this pull request
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, it's me again :)
While the previous PR #237 made the docker images more secure it wasn't enough to make the official FROST-Images be run in an Openshift environment.
After consulting the official guidelines to creating images for openshift the following problem surfaced:
To adress this issue the recommended code was added to the Dockerfiles of the HTTP and MQTTP variants.
This time I went a step further and used https://github.com/minishift/minishift to test the changes in this PR successfully.