Better support for wasm and import.meta #2771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/6Bod5Rrdrfe3dHWANLZGHob4uGaQ |
This adds the import meta rollup extension which will copy assets that use this pattern:
```js
new URL('./compiler.wasm', import.meta.url);
```
Among other things, this helps support for wasm when the above pattern is used.
* Rust now uses this pattern, so bundlers can include the wasm file. https://twitter.com/RReverser/status/1365342246653018115
* Emscripten (compiles C/C++) is working on support: emscripten-core/emscripten#13571 (comment)
This will also help with other types of static assets loaded this way, such as images.
|
I think there might be an issue with the plugin I added support for Node 14. Feel free to close this, I'll get around to looking into it eventually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds the import meta rollup extension which will copy assets that use this pattern:
Among other things, this helps support for wasm when the above pattern is used.
This will also help with other types of static assets loaded this way, such as images.
Testing
Docs
No docs published yet. Should there be?