Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check externals before resolving entrypoint #3479

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Check externals before resolving entrypoint #3479

merged 1 commit into from
Jun 23, 2021

Conversation

matthewp
Copy link
Contributor

Changes

When resolving package imports we should check external as soon as possible to avoid unnecessary work. The resolve package doesn't support the node: prefix at the moment. If you want to make that external it needs to not go through the resolve flow (which is unnecessary anyways.

Testing

Test is added, but is skipped due to this bug: nodejs/node#35889 and the way that Jest runs code.

Docs

Bug fix only, N/A.

@matthewp matthewp requested a review from a team as a code owner June 23, 2021 15:50
@vercel
Copy link

vercel bot commented Jun 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/2iKkzsHjEwEeYbJ5pEQ9CPi7UCCM
✅ Preview: https://snowpack-git-extern-dep-pikapkg.vercel.app

@matthewp matthewp merged commit 110043e into main Jun 23, 2021
@matthewp matthewp deleted the extern-dep branch June 23, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants