add JSON support #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm hasn't been a lot of activity on this until just recently. Looks like node is exploring it now. How much non-standard web stuff should this be supporting? |
|
My dream would be to encourage the use of top-level dependencies that are modern and web-standard, but to forgive badly behaving / Node specific / non-standard transitive dependencies. The other tricky bit is that since Webpack & Node allow it, and it's so damn convenient, it's already happening quite a bit even in ESM packages on npm today. I could also see this being an opt-in flag to start with. |
FredKSchott
force-pushed
the
add-json-plugin
branch
from
4126c9c
to
c326670
Compare
FredKSchott
force-pushed
the
add-json-plugin
branch
from
c326670
to
1b9ad18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for dependencies that import a JSON file as a module. This isn't supported yet in ES2019 syntax, but it's common enough in Node.js & NPM ecosystem that we need to support it.