Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @snowpack/plugin-react-refresh to React scripts #829

Merged
merged 3 commits into from
Aug 17, 2020

Conversation

stramel
Copy link
Contributor

@stramel stramel commented Aug 17, 2020

Changes

Adds the @snowpack/plugin-react-refresh plugin back into the React scripts by default. The reasoning behind this is that:

It is also, pretty easy for a user to remove this plugin if they don't want to use it.

Added a peer dependency of 16.9.0 to the @snowpack/plugin-react-refresh since it requires at least that to run. (facebook/react#16604 (comment))

Testing

Tested in the @snowpack/app-template-react and @snowpack/app-template-react-typescript to ensure it was working.

@vercel
Copy link

vercel bot commented Aug 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/hjh9o7f54
✅ Preview: https://snowpack-git-fork-stramel-ms-add-fast-refresh-plugin.pikapkg.vercel.app

@stramel
Copy link
Contributor Author

stramel commented Aug 17, 2020

Although, in the CRA codebase, they say 16.10 is required. I'm going to update it to that.

@stramel stramel marked this pull request as ready for review August 17, 2020 19:22
@stramel stramel requested a review from a team as a code owner August 17, 2020 19:22
Copy link
Collaborator

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I also like the idea of dogfooding this—we test out the React templates a lot so this would help us catch bugs in the react-refresh plugin quicker.

@FredKSchott
Copy link
Owner

@drwpow can you make sure that you test manually before our 2.8 release?

@FredKSchott FredKSchott merged commit a15ab44 into FredKSchott:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants