Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force git lang to english for ungit #963

Closed
wants to merge 2 commits into from

Conversation

jung-kim
Copy link
Collaborator

fixes #959

@campersau
Copy link
Collaborator

campersau commented Sep 17, 2017

Maybe you can try LANG=en_US.UTF-8 && git?
On windows the syntax will be: set LANG=en_US.UTF-8 && git
But I haven't tested it because I use english git.

child_process.spawn already sets the env to process.env and ungit already sets the lang in bin/ungit

@jung-kim
Copy link
Collaborator Author

On second thought, this is actually more complicated than my original thought. I think even in different linux versions language specification is handled differently and it is not always guaranteed.

Not to mention I can't even test this in Windows machine.

I would need more thought around this but for now we would have to simply document this.

@jung-kim jung-kim closed this Sep 17, 2017
@jung-kim jung-kim deleted the 959 branch September 17, 2017 21:03
@campersau
Copy link
Collaborator

Just for reference: ungit already sets the env variables here https://github.com/FredrikNoren/ungit/blob/master/bin/ungit#L20

See also:
#694
#676
#176

@jung-kim
Copy link
Collaborator Author

So I've saw that and read some doc on node child process but this means that that env variable is not working. If it was applied as one would have thought we wouldn't have #959 issue to begin with.

It is possible to add LC_ALL, LANG or any other keys but for whatever reason I couldn't successfully change git lang in my mac book and thus I couldn't really validate the fixes.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't auto-apply stash when switching branches
2 participants