[1.0.0] Clean-up dependency management with a simplistic container. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 1.0 #73 +/- ##
============================================
+ Coverage 87.00% 87.02% +0.02%
- Complexity 2109 2129 +20
============================================
Files 152 154 +2
Lines 6485 6552 +67
============================================
+ Hits 5642 5702 +60
- Misses 843 850 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…s are constructed. I do not want to pull in a third party PSR container implementation for this. But I do want to fix the dependency graph in various spots (like the protocol handlers).
…t it is constructed via a container.
…ected if needed from the container.
ChadSikorra
force-pushed
the
v1-dependencies_container
branch
from
6494d5d
to
347ec13
Compare
…et from the SocketPool until the Queue is actually needed.
…rought in as needed in the handlers from the container.
…instantiated from the container.
ChadSikorra
force-pushed
the
v1-dependencies_container
branch
from
70f5c9f
to
2e0be27
Compare
…equest. Other dependencies now come from the container as needed. Remove the ClientProtocolContext and its usage.
…Options. Will need to add this to the upgrade doc, as the method for global controls on the client no longer exists with this change.
…ClientQueueInstantiator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of the way dependencies and interfaces are designed in this library is influenced from the lack of a container / dependency graph management. This is an attempt to fix up the way dependencies are built / instantiated in the library to provide cleaner interfaces / constructors / dependencies in various spots. This likely wont be a perfect solution and may require clean-up elsewhere to be fully implemented.
#50