Add some context to code gen errors #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
einarmo
force-pushed
the
improve-code-gen-error-context
branch
from
2330478 to
636f533
Compare
A bit of a rough way to do it, but it's relatively easy and not that intrusive. It's very nice to get some general context about where in the process an error occurred when generating code, so that you can CTRL-F into the offending XML file and find where the code gen gave up. This adds some basic context to `CodeGenError` that lets us capture this information and pass it along.
einarmo
force-pushed
the
improve-code-gen-error-context
branch
from
636f533 to
bf3d50d
Compare
OPC-UA Schemas use Extension for structs, not Restriction.
- Fix rendering of DateTime<Utc> - Fix rendering of Guid - Skip rendering type loader if it is empty - Properly handle native rust types - Support ListOf[Struct] types. It won't work at the top level, but I don't think that is actually valid either way.
svanharmelen
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of a rough way to do it, but it's relatively easy and not that intrusive. It's very nice to get some general context about where in the process an error occurred when generating code, so that you can CTRL-F into the offending XML file and find where the code gen gave up.
This adds some basic context to
CodeGenErrorthat lets us capture this information and pass it along. There's probably more that can be done, but this is a start.