Remove out of tree patches #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The provisioning message change patch can't be pushed upstream as it is mainly done to adapt to our CI pass criteria. The intention is to remove of the out of tree patches, thus custom pass_output.log files have been created for each platform as the serial statements on the terminal are platform specific and should have different pass_output.log files to define the pass/success criteria for each platform. Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>
This patch can be removed and substituted by using target_compile_definitions() CMake function to define `MBEDTLS_ALLOW_PRIVATE_ACCESS` for pkcs11 integration tests source files (core_pkcs11_test.c and dev_mode_key_provisioning.c) as they both need to define this macro as part of their source files to be able to access mbedtls private fields. Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>
This commit include the following changes: * Update MLEK library to latest release v24.05 * EthosU configurable arch patch is removed as the issue of the constant NPU ID `u55` has been fixed as part of v24.05 release. * Use case resources patch is modified as the user configurable use case resource file part of the patch was added to v24.05 release where the remaining part (user defined downloaded resources path) is to be available in v24.08 release. * tensorflow patch removed as the version of tensorflow dependency the new MLEK v24.05 use doesn't need this patch. * activation_buf_dram placement in .bss.NoInit region patch is removed to follow what MLEK library do regarding placement of the activation buffers in the respective linker files for each platform. This requires modification of all FRI supported platforms' linker files. * SetupMlEmbeddedEvaluationKitLibraries.cmake is modified to adapt to v24.05 release changes. Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>
This patch is modified so it can be pushed upstream The idea is to check if the `MQTT_KEEP_ALIVE_INTERVAL_SECONDS` macro is defined by the user. Where if it is not defined, a default value (5) would be used, this way the user can choose the default value or different one that is to be provided using CMake or command line. In our case, target_compile_definitions() CMake function is used to overwrite the value of the macro for mqtt integration tests. This is done to avoid maintaining a patch which is project specific. Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>
Do not define __PASTE-macro for Arm compiler patch is modified as the issue that the patch is trying to solve was already introduced before for Keil Compiler so, the condition is just modified to add Arm Compiler too. This is done to be able to push this patch upstream. Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>
This commit contains two main changes: * Update to latest commit on `freertos-pkcs11-psa` master branch. * Remove build-Update-mbedtls-version patch as it is available upstream as part of the latest commit. Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>
archigup
approved these changes
Jul 3, 2024
urutva
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR main goal is to:
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.