coremqtt-agent: Add unit tests for subscription_manager.c #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Reuben Cartwright <Reuben.Cartwright@arm.com>
The LogWarning macro was being defined via SdkLogError instead of SdkLogWarning, which made some unit test cases inaccurate. LogWarning is now defined using the SdkLogWarning fake function. Signed-off-by: Reuben Cartwright <Reuben.Cartwright@arm.com>
Previously, removeSubscription did not produce any output, nor return a value if it failed to remove a subscription (e.g. if the subscription did not exist). This commit makes removeSubscription return true if successful, and false otherwise. This commit also documents this change. Signed-off-by: Reuben Cartwright <Reuben.Cartwright@arm.com>
Adds ~35 unit tests covering all functions in the file and some edge cases. Also modifies CMakeLists.txt to include the .cpp test file. Signed-off-by: Reuben Cartwright <Reuben.Cartwright@arm.com>
aggarg
approved these changes
Sep 24, 2024
kar-rahul-aws
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies mocks to support subscription_manager.c, and implements 32 unit tests for the file.
This PR also adds one change to subscription_manager.c's debug logging.
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.