aws-iot: Unit test and debug ota_agent_task.c #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit expands mock coverage across the FRI codebase, adding and modifying existing mocks. The mocks added are intended to support testing of `ota_agent_task.c`. Signed-off-by: Reuben Cartwright <Reuben.Cartwright@arm.com>
Some files were used by ota_agent_task.c but not directly included. This commit fixes this. Signed-off-by: Reuben Cartwright <Reuben.Cartwright@arm.com>
This commit makes the static functions in ota_agent_task.c visible if the UNIT_TESTING macro is defined. The methodology is documented already in `unit_testing.md`. This is justified because: - These functions need to be tested. - Functions other than `vStartOtaTask` cannot be refactored to be non-static, as only `vStartOtaTask` should be called in another file. Signed-off-by: Reuben Cartwright <Reuben.Cartwright@arm.com>
The function `otaAppCallback` is called upon an event such as a new file block being received, or the OTA image being activated. The function then redundantly checks the OTA state via `OTA_GetState`, which reduces code clarity via duplication including redundant calls to the ota update's active and inactive hooks. This fix has been tested via passing Arm's internal CI. Signed-off-by: Reuben Cartwright <Reuben.Cartwright@arm.com>
Adds 76 unit tests. The CMakeLists.txt within the tests subdirectory are also modified so that the tests run on calling ctest. Signed-off-by: Reuben Cartwright <Reuben.Cartwright@arm.com>
This commit fixes usage of memcpy with potentially user-defined inputs, without checking that the buffer could fit these inputs. Signed-off-by: Reuben Cartwright <Reuben.Cartwright@arm.com>
aggarg
approved these changes
Sep 27, 2024
kar-rahul-aws
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR expands mock coverage across the FRI codebase, adding and
modifying existing mocks.
The mocks added are intended to support testing of ota_agent_task.c.
76 tests are added for ota_agent_task.c, and unsafe usage of memcpy
is fixed in the file under test.
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.