Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix permissions / build caching of docker #576

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Fix permissions / build caching of docker #576

merged 2 commits into from
Jul 14, 2023

Conversation

qpSHiNqp
Copy link
Contributor

@qpSHiNqp qpSHiNqp commented Apr 6, 2023 •
edited
Loading

Fixed directories path / permissions in Dockerfile.
Also Dockerfile pip install steps are optimized to make use of DLC.
This should fix #574

@brothercorvo brothercorvo added this to the 2.1 milestone Apr 6, 2023
@brothercorvo brothercorvo requested a review from hickey April 6, 2023 12:22
@brothercorvo
Copy link
Collaborator

@hickey can you please review this PR?

@AlgMi
Copy link

AlgMi commented Apr 7, 2023 •
edited
Loading

Image build fails with older docker engine version such as 20.10.5 (latest version from raspian repository). Upgrade to 23+ fixes the issue.
Step 8/17 : COPY --chown=freetak:freetak ./requirements.txt setup.py README.md . When using COPY with more than one source file, the destination must be a directory and end with a /

@qpSHiNqp
Copy link
Contributor Author

@AlgMi Thanks for your review. I think this commit, dd9ea37, fixes the issue with 20.10.5.

@qpSHiNqp qpSHiNqp changed the base branch from master to FTS_2.1 May 11, 2023 04:07
@brothercorvo brothercorvo merged commit 8a389f2 into FreeTAKTeam:FTS_2.1 Jul 14, 2023
@RadioAndrea RadioAndrea mentioned this pull request Nov 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naman108 naman108 Awaiting requested review from naman108

@durinwinter durinwinter Awaiting requested review from durinwinter

@hickey hickey Awaiting requested review from hickey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

Docker container doesn't start
3 participants
@qpSHiNqp @brothercorvo @AlgMi