Feature/container volume #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed config file handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BLUF
Changes bind-mounts to the newer volumes since bind-mounts are confusing, hard, and are harming user experience.
Why
Bind mounts are confusing to users, and can sometimes have strange permissions. Additionally, they are not compatible with many docker desktop offerings, in particular docker desktop for windows. Many users are additionally not familiar with UIDs and thus cannot effectively set permissions properly to make the system work. This can leave them more vulnerable to attacks when running on shared systems if the permissions they end up on are too permissive.
Simplifying the persistent storage for the containers seems appropriate given the challenges encountered by users.
How
Since configuration of the server was already accessible by environment variable, I created a list of the ones I felt were most important and added them to the compose file. Use of all environment variables is of course possible, but many of them probably don't need to be exposed except for highly skilled users in strange use cases.
Other notes
This will need to be replicated to the FreeTAKHub-Installation repo
Documentation will need to be updated/added in FreeTAKServer-User-Docs