Fix ui properties not getting cleared

FreeTubeApp · Sep 15, 2024 · d9a27b8 · d9a27b8
1 parent 1e5c6ef
commit d9a27b8
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.js b/src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.js
@@ -2717,6 +2717,16 @@ export default defineComponent({
         await player.destroy()
         player = null
       }
+
+      // shaka-player doesn't clear these itself, which prevents shaka.ui.Overlay from being garbage collected
+      // Should really be fixed in shaka-player but it's easier just to do it ourselves
+      if (container.value) {
+        container.value.ui = null
+      }
+
+      if (video.value) {
+        video.value.ui = null
+      }
     }
 
     expose({