[Bug]: Thumbnail links are sometimes saved to playlists.db

[TheodorSmall]

Guidelines

• I have encountered this bug in the latest release of FreeTube.
• I have encountered this bug in the official downloads of FreeTube.
• I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
• I have searched the documentation for information that matches the description of the bug I want to file, without success.
• This issue contains only one bug.

Describe the bug

1. Use invidious API (preferably disable "fallback to secondary API") and select instance 1
2. Save a playlist from YT
3. Optionally change the invidious instance to instance 2 and assume instance 1 is no longer working
4. In playlists.db, you will find that there are some attributes to the videos of a playlist that are never used.

These attributes would not be saved when adding the videos one by one to the playlist:

• videoThumbnails
• authorUrl
• liveNow
• index

Expected Behavior

The attributes should be removed when saving the playlist.

Issue Labels

inconsistent behavior

FreeTube Version

Every version since playlists could be copied and saved locally.

Operating System Version

Artix Linux

Installation Method

.pacman, built from source

Primary API used

Invidious API

Last Known Working FreeTube Version (If Any)

unknown, probably none

Additional Information

No response

Nightly Build

• I have encountered this bug in the latest nightly build.

[efb4f5ff-1298-471a-8973-3d47447115dc]

I cant seem to find the identifier for the thumbnail links that are listed in the playlists.db. Are you sure you are talking about the right file?

[github-actions]

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

[TheodorSmall]

In fact, playlists.db is the right file, and although the video thumbnails should not be saved there, they are saved with the playlist, however only when adding multiple videos at once. The fix is quite easy because there is already a list of "undesired attributes" in the addVideos function in src/renderer/store/modules/playlists.js.
There are also a few other attributes that are only saved when adding multiple videos. These are all additional attributes that are not yet contained in the list:

• videoThumbnails
• authorUrl
• liveNow
• index

This is not a privacy issue, since the links in question are never read.