-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add playlist progress bar #2402
Conversation
could use some css
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix lint warnings
Would also like to see the color of the progress bar gets adjusted to the color u choose in the settings under Theme settings > secondary theme settings
idk if those changes to the package.json or yarn.lock are ok but it wouldent lint without them :/
Head branch was pushed to by a user without write access
fixed and fixed, although the theming is a bit odd. |
30k lines added and 7k removed? I think something didnt go well. |
i dont think i was supposed to track yarn.lock or package-lock.json |
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/renderer/components/watch-video-playlist/watch-video-playlist.css
Outdated
Show resolved
Hide resolved
src/renderer/components/watch-video-playlist/watch-video-playlist.vue
Outdated
Show resolved
Hide resolved
Not too sure if having a progress bar will make sense 100% of the time. What if the user is shuffling through the playlist? This doesn't seem to account for reverse order of playlists either. I don't see this as being as beneficial as we might think it will be. Open to other opinions however. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about only showing this when the order is "ascending" (with shuffling disabled)
We can figure out if that's useful for "reverse order" (I don't even know that exists)
But yup in this case this new components should only be displayed sometimes
Head branch was pushed to by a user without write access
thx @PikachuEXE Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
Head branch was pushed to by a user without write access
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
Head branch was pushed to by a user without write access
Im checking for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally
Screen.Recording.2022-07-21.at.10.30.54.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@absidue or @ChunkyProgrammer one more approval needed. Review if u got some spare time. |
Okay so I realised that fixing that issue requires more CSS and changing the layout, so I'm happy getting this merged and I'll create a PR to fix that issue afterwards. That way I can also make sure that the CSS changes I want to make will work with the newer CSS on the development branch (I tried rebasing but the commits with the package.json, package-lock.json and yarn.lock files break rebasing). |
could use some css
add playlist progress bar
Important note
We may remove your pull request if you do not use this provided PR template correctly.
Pull Request Type
Please select what type of pull request this is:
Related issue
Please link the issue your pull request is referring to. If this pull request fully resolves the relevant issue, put "closes" before the issue number. Example: "closes #123456".
Description
when whatching a playlist, it displays a little progress bar to show you your progress through the playlist.
Screenshots (if appropriate)
![image](https://user-images.githubusercontent.com/78005038/179372152-c65342f8-bf5f-475c-966c-02841d235250.png)
Please add before and after screenshots if there is a visible change.
Testing (for code that is not small enough to be easily understandable)
Has this pull request been tested? y
Please describe shortly how you tested it and whether there are any ramifications remaining.
it works.
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.
needs css