Update top nav search input to open new window on shift click/enter

[PikachuEXE]

Pull Request Type
Please select what type of pull request this is:

• Feature Implementation

Related issue
N/A

Description
Opening a new window, loading channel and start searching seems wasting time
Browsers have search bar to open search in new tab/window already

Top nav search bar updated to open new window on shift click (on search/go button) or shift enter (on input bar)

Clicking search suggestion with shift still won't open a new window (Can be changed if needed)

Screenshots (if appropriate)

Screen.Recording.2022-07-31.at.11.00.54.mov

Testing (for code that is not small enough to be easily understandable)
Enter

• Random search string
• Channel/playlist/video URL

And perform

• Shift click on search/go button
• Shift + Enter

Desktop (please complete the following information):

• OS: MacOS
• OS Version: 12.1
• FreeTube version: 9fa4a5a

Additional context
Add any other context about the problem here.

[absidue]

Should this be documented in the docs?

[PikachuEXE]

Sure!
Just not sure where to put it...
Let me study

[PikachuEXE]

There is no doc about the main nav search (coz not much to document right now)
Probably need a new doc?

[absidue]

Please fix the merge conflicts

[PikachuEXE]

@absidue Done~

[absidue]

Looks good.

Tested it with various video, channel and playlist URLs, as well as a bunch of search queries

[absidue]

Not sure about the docs, maybe on the keyboard shortcuts page we could have a small section with special ones?

[PikachuEXE]

Will update doc after this is all working

[PikachuEXE]

Hmmm what's holding this PR's review?

[absidue]

@ChunkyProgrammer @efb4f5ff-1298-471a-8973-3d47447115dc When you have time could you please review this PR? :)

[efb4f5ff-1298-471a-8973-3d47447115dc]

Testing (for code that is not small enough to be easily understandable)
Enter

Random search string
Channel/playlist/video URL
And perform

Shift click on search/go button
Shift + Enter

Im not sure if im testing this right everything looks to do the same as before.

[PikachuEXE]

I am using this (in my custom build but tested in dev too) on windows and macos
Not sure what makes it not working...

[absidue]

It worked when I tested it, the biggest change since then was the Electron version upgrade, so that might have broken this PR.

[PikachuEXE]

@absidue I am using my custom build with electron 20 included (but when tested with dev it was electron 16)
You can merge dev branch after checking out this branch to see if that makes it work...

[PikachuEXE]

I just tested with yarn dev (with old electron 16 that means)
Both Shift + Enter + Shift + button click opens a new window for me

[absidue]

@efb4f5ff-1298-471a-8973-3d47447115dc It works fine for me too, even when I rebase on the development branch. The new window is opened right on top of the old one, so it might be difficult to tell when a new window has been opened.

[efb4f5ff-1298-471a-8973-3d47447115dc]

Ah yes it was difficult to spot that it opened a new window. User error on my end. LGTM