Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve responsiveness of Hide Videos From Channels #2994

Merged
merged 6 commits into from
Dec 30, 2022
Merged

Improve responsiveness of Hide Videos From Channels #2994

merged 6 commits into from
Dec 30, 2022

Conversation

MarmadileManteater
Copy link
Contributor

Improve responsiveness of Hide Videos From Channels section in Settings

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Description

This PR aims to improve the mobile responsiveness of the Hide Videos From Channels input by adjusting the alignment of the action button and adjusting the whitespace surrounding the section.

Currently, the action icon is absolutely positioned within the relative ft-input-component. The ft-input-component contains a label which is displayed before the input element, and this can cause the icon to become misaligned if the label is taller than the top position of the icon. This PR aims to fix this by adding a relatively positioned wrapper around just the input and action icon. This should ensure that the action icon remains in line with the input even if the height of the label changes due to text wrapping.

Additionally, there is a lot of space between the Hide Videos From Channel section and the above section on small displays, so this PR aims to address this by hiding the line break in-between these sections with a media query. It may make more sense to use a margin/padding which changes based on a media query instead of hiding and showing the existing line-break.

Screenshots

(the below screenshots are from a 412px wide window)

before: after:

Testing

  1. yarn dev
  2. Open the Settings view
  3. Navigate to Distraction Free Settings
  4. Reduce the width of the window to something below 576px
  5. Make sure that the Hide Videos From Channels section doesn't contain any overflow

It would also make sense to do a run through of all other ft-inputs which display an action icon.

Desktop

  • OS: Windows 10
  • OS Version: Pro Version 21H2 Installed on ‎4/‎3/‎2022 OS build 19044.1889 Experience Windows Feature Experience Pack 120.2212.4180.0
  • FreeTube version: 0.18.0

Additional context

This can also be tested in a web build; however, there is currently an issue with the web build which is resolved by #2991. I went ahead and tested this PR in the web build by adding the additional fallback for fs/promises to the web webpack config which is present in that PR, and it seems to work fine.

I am unsure if the break-point I used is the best one to use. I tried to pick a pretty standard break-point, but I am aware that FreeTube uses a lot of non-standard breakpoints, so it might make more sense for this to use one of the already existing breakpoints in FT.

@MarmadileManteater
Add wrapper in ft-input to correct absolute pos
766102f 
Previously, the action icon was absolutely positioned
to the relative `ft-input-component`; however,
when the label wrapped (on small displays), the height of the
ft-input-component changed, and the icon would overflow
the bottom of the component.  Now, it should be absolutely
positioned to the relative `inputWrapper` which
begins with the top of the input element, and thus, it should
not change position based on the height of the label making it
easier to ensure it is in the right position.
@MarmadileManteater
Modify wrapper to not interfere with existing components
00b0798
@MarmadileManteater
Make ft-input-tags width: 100% on small displays
bc4046e 
There isn't a lot of screen real estate on small displays, so
this component should just expand to fill it instead of crunching
in on itself.
@MarmadileManteater
Modify media queries to use more standard breakpoint
cf11e67 
# Conflicts:
#	src/renderer/components/ft-input/ft-input.css
@MarmadileManteater
Hide line-break in distraction-settings on small displays
c419746
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 25, 2022 22:29
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 25, 2022
@ChunkyProgrammer
Copy link
Member

There's a github lint issue btw

PikachuEXE
PikachuEXE requested changes Dec 26, 2022
View reviewed changes
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested but the lint warning need to be fixed
image

src/renderer/components/distraction-settings/distraction-settings.vue Outdated
@@ -104,7 +104,7 @@
/>
</div>
</div>
<br>
<br class="hide-on-mobile" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint Warning

auto-merge was automatically disabled December 29, 2022 17:27

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 29, 2022 17:27
@FreeTubeBot FreeTubeBot merged commit 7e75710 into FreeTubeApp:development Dec 30, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 30, 2022
@absidue
Copy link
Member

absidue commented Dec 30, 2022

The inputWrapper span introduced in this PR is overlayed on top of the clear button in the main search bar, so you can no longer click it.

@absidue
Copy link
Member

absidue commented Dec 30, 2022

Sorry it's my fault for not testing that specific part of FreeTube while testing this PR.

@PikachuEXE PikachuEXE mentioned this pull request Dec 31, 2022
Merged
4 tasks
@PikachuEXE
Copy link
Collaborator

@absidue #3016

MarmadileManteater added a commit to MarmadileManteater/FreeTubeAndroid that referenced this pull request Jan 22, 2023
@MarmadileManteater
Base Cordova build off of upstream web build (#84)
c7e7e7e 
* ! Fix incorrect selector (meant to be multiple targets not nested) (FreeTubeApp#2962)

* Translated using Weblate (German)

Currently translated at 100.0% (651 of 651 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/de/

* Translated using Weblate (Finnish)

Currently translated at 99.5% (648 of 651 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/fi/

* Translated using Weblate (French)

Currently translated at 100.0% (651 of 651 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/fr/

* Translated using Weblate (Italian)

Currently translated at 100.0% (651 of 651 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/it/

* Translated using Weblate (English (United Kingdom))

Currently translated at 100.0% (651 of 651 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/en_GB/

* Fix docs link in the data settings section (FreeTubeApp#2981)

* Cleanup and simplify the settings password code (FreeTubeApp#2982)

* Translated using Weblate (Portuguese)

Currently translated at 100.0% (651 of 651 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/pt/

* Translated using Weblate (Hindi)

Currently translated at 23.3% (152 of 651 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/hi/

* Update stale.yml (FreeTubeApp#2985)

* Translated using Weblate (Croatian)

Currently translated at 100.0% (651 of 651 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/hr/

* Set width so that overflow css rules are applied. (FreeTubeApp#2988)

Added overflow-wrap break word so that more of the clipped title is
displayed.

Co-authored-by: Simon Epstein <simon.epstein@67bricks.com>

* Support extra youtube embed playlist links (FreeTubeApp#2972)

* Fix strange embed playlist links missing /

* support embed/videoseries links

* remove duplicated replace line

Co-authored-by: petaded <code@zikl.co.uk>

* Option to skip through the video by scrolling (FreeTubeApp#2418)

* initial commit

* remove extra play button toggle

* add missing comment

Co-authored-by: Alin <ai6@tutanota.com>
Co-authored-by: ChunkyPtogrammer <78101139+ChunkyProgrammer@users.noreply.github.com>

* Translated using Weblate (Spanish)

Currently translated at 100.0% (653 of 653 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/es/

* Translated using Weblate (Polish)

Currently translated at 100.0% (653 of 653 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/pl/

* Translated using Weblate (Turkish)

Currently translated at 100.0% (653 of 653 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/tr/

* Translated using Weblate (Galician)

Currently translated at 100.0% (653 of 653 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/gl/

* Translated using Weblate (Ukrainian)

Currently translated at 100.0% (653 of 653 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/uk/

* Translated using Weblate (Chinese (Simplified))

Currently translated at 100.0% (653 of 653 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/zh_Hans/

* Translated using Weblate (Chinese (Traditional))

Currently translated at 100.0% (653 of 653 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/zh_Hant/

* Translated using Weblate (Italian)

Currently translated at 100.0% (653 of 653 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/it/

* Translated using Weblate (Czech)

Currently translated at 100.0% (653 of 653 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/cs/

* Improve accessibility of Watch View (FreeTubeApp#2986)

* Improve Watch page accessibility

Co-Authored-By: Jason <84899178+jasonhenriquez@users.noreply.github.com>

* fix title issue, remove unused gotochannel function

Co-authored-by: Jason <84899178+jasonhenriquez@users.noreply.github.com>

* Translated using Weblate (Portuguese (Portugal))

Currently translated at 100.0% (653 of 653 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/pt_PT/

* Translated using Weblate (Japanese)

Currently translated at 100.0% (653 of 653 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/ja/

* Translated using Weblate (Portuguese)

Currently translated at 100.0% (653 of 653 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/pt/

* Translated using Weblate (Polish)

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/pl/

* Translated using Weblate (Arabic)

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/ar/

* Translated using Weblate (Spanish)

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/es/

* Translated using Weblate (Portuguese)

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/pt/

* Translated using Weblate (Turkish)

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/tr/

* Translated using Weblate (Czech)

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/cs/

* Translated using Weblate (Ukrainian)

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/uk/

* Translated using Weblate (Chinese (Simplified))

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/zh_Hans/

* Translated using Weblate (Italian)

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/it/

* Translated using Weblate (Hungarian)

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/hu/

* Translated using Weblate (Hebrew)

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/he/

* Translated using Weblate (Galician)

Currently translated at 99.8% (656 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/gl/

* Translated using Weblate (Galician)

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/gl/

* Translated using Weblate (German)

Currently translated at 99.3% (653 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/de/

* Translated using Weblate (Norwegian Bokmål)

Currently translated at 82.0% (539 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/nb_NO/

* Translated using Weblate (Chinese (Simplified))

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/zh_Hans/

* Fixing Stale bot (FreeTubeApp#2992)

* Fix insecure coookie error (FreeTubeApp#2990)

* ! Fix possible to do both actions in video player by scrolling (FreeTubeApp#2989)

"Scroll playback rate over video player" and "Skip by Scrolling Over Video Player"

* Translated using Weblate (Russian)

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/ru/

* Translated using Weblate (Norwegian Bokmål)

Currently translated at 89.8% (590 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/nb_NO/

* Translated using Weblate (Chinese (Traditional))

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/zh_Hant/

* Bump videojs-contrib-quality-levels from 2.2.1 to 3.0.0 (FreeTubeApp#2996)

Bumps [videojs-contrib-quality-levels](https://github.com/videojs/videojs-contrib-quality-levels) from 2.2.1 to 3.0.0.
- [Release notes](https://github.com/videojs/videojs-contrib-quality-levels/releases)
- [Changelog](https://github.com/videojs/videojs-contrib-quality-levels/blob/main/CHANGELOG.md)
- [Commits](videojs/videojs-contrib-quality-levels@v2.2.1...v3.0.0)

---
updated-dependencies:
- dependency-name: videojs-contrib-quality-levels
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump marked from 4.2.4 to 4.2.5 (FreeTubeApp#2998)

Bumps [marked](https://github.com/markedjs/marked) from 4.2.4 to 4.2.5.
- [Release notes](https://github.com/markedjs/marked/releases)
- [Changelog](https://github.com/markedjs/marked/blob/master/.releaserc.json)
- [Commits](markedjs/marked@v4.2.4...v4.2.5)

---
updated-dependencies:
- dependency-name: marked
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump sass from 1.57.0 to 1.57.1 (FreeTubeApp#2995)

Bumps [sass](https://github.com/sass/dart-sass) from 1.57.0 to 1.57.1.
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md)
- [Commits](sass/dart-sass@1.57.0...1.57.1)

---
updated-dependencies:
- dependency-name: sass
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Lazy load playlist components to improve performance (FreeTubeApp#2993)

* Update app menu to add items for side nav items (FreeTubeApp#2965)

* * Update app menu to add items for side nav items

* * Show app menu items accoridng to user settings

* * Update app menu on setting update

* ! Fix setting values reading when db entry(s) absent

* $ Use `?.` instead of try/catch

Suggested by absidue

Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>

Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>

* Translated using Weblate (Russian)

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/ru/

* Escape special characters in channel names in ompl export (FreeTubeApp#3004)

* Import the product name instead of using a define for it (FreeTubeApp#3003)

* Use path.sep instead of working out the directory separator ourselves (FreeTubeApp#3002)

* Bump @babel/core from 7.20.5 to 7.20.7 (FreeTubeApp#2997)

Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.20.5 to 7.20.7.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.20.7/packages/babel-core)

---
updated-dependencies:
- dependency-name: "@babel/core"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Only show prompt close button when it is needed (FreeTubeApp#3001)

* Translated using Weblate (German)

Currently translated at 99.6% (655 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/de/

* Translated using Weblate (Finnish)

Currently translated at 99.0% (651 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/fi/

* Translated using Weblate (French)

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/fr/

* Translated using Weblate (English (United Kingdom))

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/en_GB/

* Migrate the trending page to YouTube.js (FreeTubeApp#3005)

* Migrate the trending page to YouTube.js

* Move more of the logic to the local API file

* This function doesn't need to be exported anymore

* Translated using Weblate (Russian)

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/ru/

* Translated using Weblate (Japanese)

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/ja/

* Translated using Weblate (Russian)

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/ru/

* Switch from sync fs APIs to fs/promises (FreeTubeApp#2991)

* Switch from sync fs APIs to fs/promises

* Fix error and await storyboard creation

* Start a new file for filesystem helpers starting with pathExists

* Translated using Weblate (Portuguese (Portugal))

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/pt_PT/

* Translated using Weblate (Croatian)

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/hr/

* Translated using Weblate (Bulgarian)

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/bg/

* Translated using Weblate (Bulgarian)

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/bg/

* Translated using Weblate (Norwegian Nynorsk)

Currently translated at 75.0% (493 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/nn/

* Update conflicts.yml (FreeTubeApp#3009)

* Update conflicts.yml

* Delete dummy-conflicts.yml

* Improve responsiveness of `Hide Videos From Channels` (FreeTubeApp#2994)

* Add wrapper in `ft-input`  to correct absolute pos

Previously, the action icon was absolutely positioned
to the relative `ft-input-component`; however,
when the label wrapped (on small displays), the height of the
ft-input-component changed, and the icon would overflow
the bottom of the component.  Now, it should be absolutely
positioned to the relative `inputWrapper` which
begins with the top of the input element, and thus, it should
not change position based on the height of the label making it
easier to ensure it is in the right position.

* Modify wrapper to not interfere with existing components

* Make ft-input-tags `width: 100%` on small displays

There isn't a lot of screen real estate on small displays, so
this component should just expand to fill it instead of crunching
in on itself.

* Modify media queries to use more standard breakpoint

# Conflicts:
#	src/renderer/components/ft-input/ft-input.css

* Hide line-break in distraction-settings on small displays

* Fix lint issue by removing self-close from `br`

* Translated using Weblate (Russian)

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/ru/

* Translated using Weblate (Russian)

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/ru/

* Translated using Weblate (Italian)

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/it/

* Translated using Weblate (Czech)

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/cs/

* Fix styling of the comment author text (FreeTubeApp#3012)

* Parse channel handles in video descriptions (FreeTubeApp#3011)

* Use a function for menu navigations (FreeTubeApp#3010)

* Update copyleft year to 2023 (FreeTubeApp#3017)

* Remove unused meta.icon properties from the router config (FreeTubeApp#3000)

* Fix clear button covered by new input wrapper (FreeTubeApp#3016)

* $ Fix CSS warnings

* ! Fix clear button covered by new input wrapper

* Make getVideoParamsFromUrl and showExternalPlayerUnsupportedActionToast helpers (FreeTubeApp#3018)

* Translated using Weblate (Czech)

Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/cs/

* Add option to display distraction free titles (FreeTubeApp#2987)

* 2953 Added boilerplate to manage setting.

* Hooked in distraction free title to video list view.

* Tweaked the regexp to include apostrophe when looking for runs.

Also only change case for runs of 3 or more, to avoid messing with
common abbreviations.

* Addressed review feedback.

Co-authored-by: Simon Epstein <simon.epstein@67bricks.com>

* Translated using Weblate (Japanese)

Currently translated at 100.0% (658 of 658 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/ja/

* Translated using Weblate (Bulgarian)

Currently translated at 100.0% (658 of 658 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/bg/

* Translated using Weblate (Hungarian)

Currently translated at 100.0% (658 of 658 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/hu/

* Translated using Weblate (Czech)

Currently translated at 100.0% (658 of 658 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/cs/

* Translated using Weblate (Ukrainian)

Currently translated at 100.0% (658 of 658 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/uk/

* Fix no sources error on the watch page (FreeTubeApp#3019)

* Translated using Weblate (Chinese (Simplified))

Currently translated at 100.0% (658 of 658 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/zh_Hans/

* Translated using Weblate (Chinese (Simplified))

Currently translated at 100.0% (658 of 658 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/zh_Hans/

* Translated using Weblate (Italian)

Currently translated at 100.0% (658 of 658 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/it/

* Translated using Weblate (Turkish)

Currently translated at 100.0% (658 of 658 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/tr/

* Translated using Weblate (Greek)

Currently translated at 100.0% (658 of 658 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/el/

* Translated using Weblate (Hebrew)

Currently translated at 100.0% (658 of 658 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/he/

* Translated using Weblate (Icelandic)

Currently translated at 100.0% (658 of 658 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/is/

* Bump actions/stale from 6 to 7 (FreeTubeApp#2999)

* Bump actions/stale from 6 to 7

Bumps [actions/stale](https://github.com/actions/stale) from 6 to 7.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v6...v7)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Only give necessary permissions to workflow

* readd spacing

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: ChunkyProgrammer <78101139+ChunkyProgrammer@users.noreply.github.com>

* Translated using Weblate (Portuguese (Portugal))

Currently translated at 100.0% (658 of 658 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/pt_PT/

* Translated using Weblate (Spanish)

Currently translated at 100.0% (658 of 658 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/es/

* Translated using Weblate (Portuguese)

Currently translated at 100.0% (658 of 658 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/pt/

* Translated using Weblate (Galician)

Currently translated at 100.0% (658 of 658 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/gl/

* Translated using Weblate (Russian)

Currently translated at 100.0% (658 of 658 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/ru/

* Fix workflow warnings (FreeTubeApp#3024)

* update actions

* update node12 actions

fix version

* update node12 actions

* Use the new retrieve_player option in YouTube.js (FreeTubeApp#3022)

* Translated using Weblate (Chinese (Traditional))

Currently translated at 100.0% (658 of 658 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/zh_Hant/

* update linters & add stylelint (FreeTubeApp#3023)

* update linters, add stylelint, switch from sass to scss

* remove unused babel-eslint module

* fix spacing in scss files

* dont use npm in script calls

* dont error for `:deep` selector in css

* ! Fix Ctrl/Cmd + C unable to copy text when viewing video (FreeTubeApp#3027)

* Add support for lefthook local config for setting up option `rc` (FreeTubeApp#2961)

* ^ Update lefthook to 1.2.6

* + Add support for lefthook local config for setting up option `rc`

https://github.com/evilmartians/lefthook/blob/master/docs/configuration.md#rc

* Translated using Weblate (French)

Currently translated at 100.0% (658 of 658 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/fr/

* Translated using Weblate (Portuguese (Brazil))

Currently translated at 100.0% (658 of 658 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/pt_BR/

* Bump json5 from 1.0.1 to 1.0.2 (FreeTubeApp#3029)

Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Translated using Weblate (Croatian)

Currently translated at 100.0% (658 of 658 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/hr/

* Fix CSS variables (FreeTubeApp#3030)

* Translated using Weblate (Arabic)

Currently translated at 100.0% (658 of 658 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/ar/

* Add more electron guards (FreeTubeApp#3031)

* Migrate search to YouTube.js (FreeTubeApp#3028)

* Migrate search to YouTube.js

* Fix linting issue

* Improve accessibility of Channel View (FreeTubeApp#2984)

* Improve channel info bar

* Reduce width of channel search bar

* fix sizing

* improve channel view accessibility

Co-Authored-By: Jason <84899178+jasonhenriquez@users.noreply.github.com>

* Update src/renderer/components/ft-channel-bubble/ft-channel-bubble.js

Co-authored-by: PikachuEXE <pikachuexe@gmail.com>

* Stop space from clicking channel-bubble (links)

Co-authored-by: vallode <18506096+vallode@users.noreply.github.com>
Co-authored-by: Jason <84899178+jasonhenriquez@users.noreply.github.com>
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>

* Translated using Weblate (Russian)

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/ru/

* Translated using Weblate (Italian)

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/it/

* Translated using Weblate (Greek)

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/el/

* Translated using Weblate (Turkish)

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/tr/

* Translated using Weblate (Hebrew)

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/he/

* Translated using Weblate (Chinese (Simplified))

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/zh_Hans/

* Translated using Weblate (Arabic)

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/ar/

* Translated using Weblate (Icelandic)

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/is/

* Translated using Weblate (French)

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/fr/

* Translated using Weblate (Polish)

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/pl/

* Translated using Weblate (Croatian)

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/hr/

* Translated using Weblate (Spanish)

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/es/

* Translated using Weblate (Czech)

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/cs/

* Translated using Weblate (Galician)

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/gl/

* Translated using Weblate (Bulgarian)

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/bg/

* Translated using Weblate (Ukrainian)

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/uk/

* Translated using Weblate (Portuguese (Portugal))

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/pt_PT/

* Translated using Weblate (Portuguese)

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/pt/

* Migrate the watch page to YouTube.js (FreeTubeApp#3035)

* Migrate the watch page to YouTube.js

* Fix YouTube.js exclusion in the web build

* Translated using Weblate (Chinese (Traditional))

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/zh_Hant/

* Translated using Weblate (Hungarian)

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/hu/

* Translated using Weblate (German)

Currently translated at 99.8% (658 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/de/

* Use webpack externals to exclude dependencies (FreeTubeApp#3036)

* Hide the proxy settings in the web build (FreeTubeApp#3037)

* Update mastodon link to `@FreeTube@fosstodon.org` (FreeTubeApp#3038)

AFAIK mastodon.technology is shut down

* Bump prettier from 2.8.1 to 2.8.2 (FreeTubeApp#3044)

Bumps [prettier](https://github.com/prettier/prettier) from 2.8.1 to 2.8.2.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@2.8.1...2.8.2)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @babel/core from 7.20.7 to 7.20.12 (FreeTubeApp#3043)

Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.20.7 to 7.20.12.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.20.12/packages/babel-core)

---
updated-dependencies:
- dependency-name: "@babel/core"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump babel-loader from 9.1.0 to 9.1.2 (FreeTubeApp#3042)

Bumps [babel-loader](https://github.com/babel/babel-loader) from 9.1.0 to 9.1.2.
- [Release notes](https://github.com/babel/babel-loader/releases)
- [Changelog](https://github.com/babel/babel-loader/blob/main/CHANGELOG.md)
- [Commits](babel/babel-loader@v9.1.0...v9.1.2)

---
updated-dependencies:
- dependency-name: babel-loader
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump eslint-plugin-jsonc from 2.5.0 to 2.6.0 (FreeTubeApp#3040)

Bumps [eslint-plugin-jsonc](https://github.com/ota-meshi/eslint-plugin-jsonc) from 2.5.0 to 2.6.0.
- [Release notes](https://github.com/ota-meshi/eslint-plugin-jsonc/releases)
- [Changelog](https://github.com/ota-meshi/eslint-plugin-jsonc/blob/master/CHANGELOG.md)
- [Commits](ota-meshi/eslint-plugin-jsonc@v2.5.0...v2.6.0)

---
updated-dependencies:
- dependency-name: eslint-plugin-jsonc
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump postcss from 8.4.20 to 8.4.21 (FreeTubeApp#3041)

Bumps [postcss](https://github.com/postcss/postcss) from 8.4.20 to 8.4.21.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.20...8.4.21)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Translated using Weblate (Portuguese)

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/pt/

* Generate local API sessions locally (FreeTubeApp#3052)

* Move invidious out of stores (FreeTubeApp#3045)

* move invidious out of stores

* fix getting more replies & local api fallback for comments

* throw error if error message found in invidious response

* fix issue with data setting

* fix issue with replacing thumbnails

* add bank line, remove slash

* Apply suggestions from code review

Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>

Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>

* small accessibility improvements (FreeTubeApp#3033)

* small accessibility improvements

* switch to routerlink for side-nav-more-options

* Translated using Weblate (English (United Kingdom))

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/en_GB/

* Add an IS_ELECTRON_MAIN define instead of runtime detection (FreeTubeApp#3056)

* Migrate live chat to YouTube.js (FreeTubeApp#3054)

* Decipher format URLs with the local API (FreeTubeApp#3053)

* ! Fix code for getting event.key lowercase value (FreeTubeApp#3061)

* Use ES6 classes for video.js components instead of videojs.extend (FreeTubeApp#3060)

* ! Fix searching in channel view broken (FreeTubeApp#3062)

* Translated using Weblate (Norwegian Nynorsk)

Currently translated at 91.9% (606 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/nn/

* Import store modules with ES6 imports instead of dynamically (FreeTubeApp#3064)

* Translated using Weblate (Norwegian Bokmål)

Currently translated at 89.8% (592 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/nb_NO/

* Translated using Weblate (Norwegian Nynorsk)

Currently translated at 95.4% (629 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/nn/

* Add a formatNumber helper and other i18n cleanup (FreeTubeApp#3055)

* Add a formatNumber helper and other i18n cleanup

* Fix import order

* Translated using Weblate (Portuguese (Brazil))

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/pt_BR/

* Translated using Weblate (Norwegian Nynorsk)

Currently translated at 97.1% (640 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/nn/

* Translated using Weblate (Spanish (Mexico))

Currently translated at 84.2% (555 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/es_MX/

* Translated using Weblate (Norwegian Nynorsk)

Currently translated at 98.7% (651 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/nn/

* Bump prettier from 2.8.2 to 2.8.3 (FreeTubeApp#3085)

Bumps [prettier](https://github.com/prettier/prettier) from 2.8.2 to 2.8.3.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@2.8.2...2.8.3)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump marked from 4.2.5 to 4.2.12 (FreeTubeApp#3076)

Bumps [marked](https://github.com/markedjs/marked) from 4.2.5 to 4.2.12.
- [Release notes](https://github.com/markedjs/marked/releases)
- [Changelog](https://github.com/markedjs/marked/blob/master/.releaserc.json)
- [Commits](markedjs/marked@v4.2.5...v4.2.12)

---
updated-dependencies:
- dependency-name: marked
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump eslint-plugin-vue from 9.8.0 to 9.9.0 (FreeTubeApp#3077)

Bumps [eslint-plugin-vue](https://github.com/vuejs/eslint-plugin-vue) from 9.8.0 to 9.9.0.
- [Release notes](https://github.com/vuejs/eslint-plugin-vue/releases)
- [Commits](vuejs/eslint-plugin-vue@v9.8.0...v9.9.0)

---
updated-dependencies:
- dependency-name: eslint-plugin-vue
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump eslint-plugin-import from 2.26.0 to 2.27.4 (FreeTubeApp#3081)

Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.26.0 to 2.27.4.
- [Release notes](https://github.com/import-js/eslint-plugin-import/releases)
- [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md)
- [Commits](import-js/eslint-plugin-import@v2.26.0...v2.27.4)

---
updated-dependencies:
- dependency-name: eslint-plugin-import
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump lefthook from 1.2.6 to 1.2.7 (FreeTubeApp#3078)

Bumps [lefthook](https://github.com/evilmartians/lefthook) from 1.2.6 to 1.2.7.
- [Release notes](https://github.com/evilmartians/lefthook/releases)
- [Changelog](https://github.com/evilmartians/lefthook/blob/master/CHANGELOG.md)
- [Commits](evilmartians/lefthook@v1.2.6...v1.2.7)

---
updated-dependencies:
- dependency-name: lefthook
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump rimraf from 3.0.2 to 4.1.0 (FreeTubeApp#3088)

Bumps [rimraf](https://github.com/isaacs/rimraf) from 3.0.2 to 4.1.0.
- [Release notes](https://github.com/isaacs/rimraf/releases)
- [Changelog](https://github.com/isaacs/rimraf/blob/main/CHANGELOG.md)
- [Commits](isaacs/rimraf@v3.0.2...v4.1.0)

---
updated-dependencies:
- dependency-name: rimraf
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump eslint-plugin-n from 15.6.0 to 15.6.1 (FreeTubeApp#3080)

Bumps [eslint-plugin-n](https://github.com/eslint-community/eslint-plugin-n) from 15.6.0 to 15.6.1.
- [Release notes](https://github.com/eslint-community/eslint-plugin-n/releases)
- [Commits](eslint-community/eslint-plugin-n@15.6.0...15.6.1)

---
updated-dependencies:
- dependency-name: eslint-plugin-n
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump eslint-plugin-vuejs-accessibility from 2.0.0 to 2.1.0 (FreeTubeApp#3082)

Bumps [eslint-plugin-vuejs-accessibility](https://github.com/vue-a11y/eslint-plugin-vuejs-accessibility) from 2.0.0 to 2.1.0.
- [Release notes](https://github.com/vue-a11y/eslint-plugin-vuejs-accessibility/releases)
- [Changelog](https://github.com/vue-a11y/eslint-plugin-vuejs-accessibility/blob/main/CHANGELOG.md)
- [Commits](vue-a11y/eslint-plugin-vuejs-accessibility@v2.0.0...v2.1.0)

---
updated-dependencies:
- dependency-name: eslint-plugin-vuejs-accessibility
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump electron from 22.0.0 to 22.0.2 (FreeTubeApp#3084)

Bumps [electron](https://github.com/electron/electron) from 22.0.0 to 22.0.2.
- [Release notes](https://github.com/electron/electron/releases)
- [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md)
- [Commits](electron/electron@v22.0.0...v22.0.2)

---
updated-dependencies:
- dependency-name: electron
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump eslint from 8.31.0 to 8.32.0 (FreeTubeApp#3083)

Bumps [eslint](https://github.com/eslint/eslint) from 8.31.0 to 8.32.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.31.0...v8.32.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Translated using Weblate (Polish)

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/pl/

* Switch from Vue.extend to defineComponent (FreeTubeApp#3066)

* Don't react when selecting the current trending tab (FreeTubeApp#3070)

* Correct argument on `invidiousGetPlaylistInfo` (FreeTubeApp#3089)

`invidiousGetPlaylistInfo` expects a `string`.

* ! Fix search view not loading result starting 2nd page via local API (FreeTubeApp#3074)

* Translated using Weblate (Norwegian Bokmål)

Currently translated at 89.9% (593 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/nb_NO/

* Translated using Weblate (Norwegian Nynorsk)

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/nn/

* Map `videos` property on Invidious API response (FreeTubeApp#3090)

`invidiousAPICall` is returning an object with a `videos` property here
instead of a list.

* Bind directive to function instead of function call (FreeTubeApp#3091)

v-if="showResult(data)" evaluates once
v-if="showResult" is reactive;

`data` also doesn't need to be passed here
because it is already accessible from `this`.

* Translated using Weblate (Russian)

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/ru/

* ! Fix searching (2nd time onward) in channel view broken (FreeTubeApp#3073)

* Use a single import for the brand icons (FreeTubeApp#3094)

* Translated using Weblate (Russian)

Currently translated at 100.0% (659 of 659 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/ru/

* Change `color: white` to `color: inherit`

(I was assuming dark mode)

* Add logic for setting proper android version codes

* Reduce the space between the top of the screen and the routerView

* Make the splash screen look better in dark mode

My logic is that light mode users won't mind a dark
splash screen, but that dark mode users will definitely
mind a light mode splash screen.

* Set the splashscreen icon

* Add check for un-updated invidious version

* Add `Cordova Settings` section

; right now, it 🏠houses a setting to
enable the `silent` mode in the background
mode plugin. I am leaving it off by default because
disabling this notification may cause Android
to more readily close the application in the
background.

* Switch from exact wait time to `splashscreen.show()`

This is so much better than just having an arbitrary delay
for the splash screen.

* Float the share links to the middle on small 📱displays

* Remove no longer necessary `if`s

* Add `fs-extra` to the dev-dependencies

; also, reorganize the build workflow

* Update reference to `move` from `fs-extra`

* Add a `shortcut icon` to `index.ejs`

* Move icon into `static`

* Explicitly set node-version

* Update gh actions

* Attempt to extract the package JSON data manually

* Add step to echo back json

* 🤷‍♀️

* Attempt json parse inside gh script

* Remove part of the read_package step

* 🤷‍♀️

* Replace percent signs with space

* Trying a multi-line string

* Try `GITHUB_ENV`

* Try a new gh action

* Rename step

* Fix naming

* Differentiate development build name

* Change `name` to `productName`

* Forgot the `Name` in `productName`

* Remove hyphen from app name

* Testing out modified release pipeline

* Fix indenting

* Correct the environment

* Switch release to environment named release

* Fix `asset_path` in upload

* remove development suffix from releaseCordova

* Adjust release `asset_path`

* Adjust `yarn build:cordova` arguments to allow --release

* Add log to tell if `release` is being set

* Add `--stacktrace` argument

* Troubleshoot signing

* 🤔 unsure why building the `--release` flag causes signing to fail

* 🔨Troubleshoot signing issues

* Remove `--release` flag from release for now

; I am having trouble with getting a release
build signed.

* Modify update checking logic slightly

* Switch the development and nightly labels;

`development` is now `nightly` and
what was `nightly` is now `release`.

* Set `buildCordova.yml` to point back to `development`
@MarmadileManteater MarmadileManteater deleted the responsiveness-hide-videos-from-channel branch March 16, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@absidue absidue absidue approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc Awaiting requested review from efb4f5ff-1298-471a-8973-3d47447115dc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MarmadileManteater @ChunkyProgrammer @absidue @PikachuEXE @FreeTubeBot