Fix "mention" in comments was rendered as link with channel URL #3351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PikachuEXE
requested review from
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Mar 25, 2023
ChunkyProgrammer
previously approved these changes
Mar 28, 2023
absidue
reviewed
Mar 30, 2023
src/renderer/helpers/api/local.js
Outdated
| // In comments, mention can be `@Channel Name` (not handle, but name) | ||
| if (CHANNEL_HANDLE_REGEX.test(trimmedText) || (options.looseChannelNameDetection && /^@/.test(trimmedText))) { | ||
| // Extra space at the end due to YT tend to include one space afterward into "channel run" `text` for "mentions" | ||
| parsedRuns.push(`<a href="https://www.youtube.com/channel/${endpoint.payload.browseId}">${trimmedText}</a> `) |
There was a problem hiding this comment.
Please only add the extra space for the comments mentions, for channel handles, the space is usually in the other text segments, so this creates double spaces in video descriptions e.g. https://youtu.be/QtwEO9aDhHw (taken from #3011 before the local API migration)
before:
after:
absidue
added
PR: changes requested
and removed
PR: waiting for review
PikachuEXE
dismissed stale reviews from ChunkyProgrammer and efb4f5ff-1298-471a-8973-3d47447115dc
via
14dd653
|
@absidue Sorry that's me being lazy, updated to extra spaces from original text and add back on output text |
PikachuEXE
requested review from
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
absidue
reviewed
Apr 1, 2023
|
@absidue Done |
PikachuEXE
added
PR: waiting for review
absidue
approved these changes
Apr 2, 2023
|
@ChunkyProgrammer @efb4f5ff-1298-471a-8973-3d47447115dc Please review and approve again 🥺. |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Apr 8, 2023
ChunkyProgrammer
approved these changes
Apr 17, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Apr 21, 2023
* development: Fix extracting chapters with handles from description (FreeTubeApp#3456) * Update video list display & watch page to not use stored watch progress when progress saving disabled (FreeTubeApp#3453) Update invidious-instances.json (FreeTubeApp#3440) Prevent loading for ever in web builds in live chat (FreeTubeApp#3449) Bump postcss from 8.4.21 to 8.4.22 (FreeTubeApp#3435) Bump html-webpack-plugin from 5.5.0 to 5.5.1 (FreeTubeApp#3432) Bump webpack from 5.78.0 to 5.79.0 (FreeTubeApp#3436) Bump sass from 1.61.0 to 1.62.0 (FreeTubeApp#3433) Fix "mention" in comments was rendered as link with channel URL (FreeTubeApp#3351) Fix live premieres being treated as non-live videos (FreeTubeApp#3358) Bump eslint-plugin-vue from 9.10.0 to 9.11.0 (FreeTubeApp#3434) Bump webpack-dev-server from 4.13.2 to 4.13.3 (FreeTubeApp#3437) Bump youtubei.js from 4.2.0 to 4.3.0 (FreeTubeApp#3438) Bump lefthook from 1.3.9 to 1.3.10 (FreeTubeApp#3439)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
N/A
Description
With local API, some mentions (with channel name not channel handle) in comments are rendered as URLs due to incorrect assumption of only channel handle would be displayed
Screenshots
Before fix
After fix
Testing
A. Video comments
B. Video description
Desktop
Additional context