Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix video comment external link parsing for local API #3448

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Fix video comment external link parsing for local API #3448

merged 1 commit into from
Apr 26, 2023

Conversation

PikachuEXE
Copy link
Collaborator

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Description

There is an error when parsing a "run" (part of a comment) from local API

endpoint.payload.url is undefined

This PR fixes it

Screenshots

Comment to be parsed
image

Actual run object from Youtubei.js
image
image

Testing

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) April 19, 2023 00:58
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Apr 19, 2023
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Cant find the comment on the YT side, are u sure this is the right url?

@PikachuEXE
Copy link
Collaborator Author

@efb4f5ff-1298-471a-8973-3d47447115dc
image

@ChunkyProgrammer
Copy link
Member

@efb4f5ff-1298-471a-8973-3d47447115dc try sorting by newest if it doesn't show up

efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found it, LGTM!

@FreeTubeBot FreeTubeBot merged commit f6d8e78 into FreeTubeApp:development Apr 26, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Apr 26, 2023
@PikachuEXE PikachuEXE deleted the fix/local-text-run-leave-youtube branch April 26, 2023 00:20
@absidue absidue mentioned this pull request Apr 30, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@absidue absidue absidue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @absidue @FreeTubeBot