Search: Add hashtags to results #3780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
|
Is it ready or WIP ._. |
|
Blocked is probably the best message for it (we are waiting for the IV pr to be merged but I don't expect any changes on my end unless something comes up in review) |
|
I can see LuanRT/YouTube.js#441 merged |
|
Yeah, that'll have to be done too |
ChunkyProgrammer
removed
the
PR: waiting for review
ChunkyProgrammer
force-pushed
the
add-support-for-hashtags-in-search-results
branch
from
57673fb
to
17a3539
Compare
absidue
reviewed
Aug 26, 2023
Co-Authored-By: absidue <48293849+absidue@users.noreply.github.com>
ChunkyProgrammer
requested review from
PikachuEXE,
absidue and
efb4f5ff-1298-471a-8973-3d47447115dc
ChunkyProgrammer
added
PR: waiting for review
absidue
reviewed
Aug 26, 2023
|
Looking at FreeTube's general heading structure, I think we can make a few improvements. But this looks in line with the existing structure. Waiting on an answer to absidue's q, but then LGTM. |
PikachuEXE
reviewed
Aug 27, 2023
|
@ChunkyProgrammer ready for review or do you still need to address some things? |
|
I still can't understand the URL generation & |
PikachuEXE
reviewed
Aug 30, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
previously requested changes
Sep 6, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
dismissed
their stale review
Missclick -.-
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Sep 6, 2023
ChunkyProgrammer
requested review from
efb4f5ff-1298-471a-8973-3d47447115dc and
PikachuEXE
PikachuEXE
approved these changes
Sep 7, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Sep 7, 2023
absidue
approved these changes
Sep 9, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Sep 11, 2023
* development: (46 commits) Translated using Weblate (Hebrew) Translated using Weblate (Hebrew) Translated using Weblate (Chinese (Simplified)) Add subscribed icon to comments (FreeTubeApp#4007) Translated using Weblate (Icelandic) Translated using Weblate (Czech) Translated using Weblate (Bulgarian) Translated using Weblate (Polish) Translated using Weblate (Arabic) Translated using Weblate (Greek) Translated using Weblate (Italian) Translated using Weblate (Chinese (Simplified)) Translated using Weblate (Hungarian) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Ukrainian) Translated using Weblate (Spanish) Translated using Weblate (Hebrew) Translated using Weblate (Turkish) Search: Add hashtags to results (FreeTubeApp#3780) Implement right-to-left interface (FreeTubeApp#3970) ... # Conflicts: # src/renderer/components/ft-element-list/ft-element-list.vue # src/renderer/components/ft-prompt/ft-prompt.css # src/renderer/components/ft-toast/ft-toast.css # src/renderer/scss-partials/_ft-list-item.scss # src/renderer/views/Playlist/Playlist.scss
ChunkyProgrammer
deleted the
add-support-for-hashtags-in-search-results
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Search: Add hashtags to results
Pull Request Type
Related issue
#3483 (comment)
Description
This PR parses hashtags in the search results
Screenshots
Testing
(Test with both Invidious and local api)
#hi, see hashtag in results#meowsee updated results + updated hashtagDesktop
Additional context
Requires iv-org/invidious#3989 to be merged and LuanRT/YouTube.js#441 to be released