Hide playlists in channel search results if "hide channel playlist" preference selected. #4454
Conversation
preference selected.
github-actions
bot
added
the
PR: waiting for review
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
kommunarr
requested review from
PikachuEXE,
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
MarmadileManteater
There was a problem hiding this comment.
Im not against the implementation of this PR but i think its getting approved a bit fast.
If hiding this on the channel page needs to be the default when hiding a tab, it should also be done for other tabs not just this one. Otherwise we'll be creating an inconsistent UX by implementing it like this. Would be bad to confuse users like this
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
|
Channel Podcasts are the only other hide-able items that appear in channel search results. From my testing, podcasts are glorified playlists, so enabling Hide Channel Playlists now also blocks podcasts in search results, which makes sense. Correct me if I'm wrong, but I don't think we have the ability to differentiate Channel Podcasts by their data payload. If there is no way to differentiate based on their data payload, we would have to make a request (well, multiple requests until end of continuation is hit...) to load all channel podcasts to hide only them if Hide Channel Podcasts is enabled. |
|
Please advise what changes I should make to the PR to get this approved. The only other thing I can think of is adding another preference to filter the channel search results. I'm not sure that is less confusing though. |
This comment was marked as resolved.
This comment was marked as resolved.
* development: Hide playlists in channel search results if "hide channel playlist" preference selected. (FreeTubeApp#4454) Fix issue with subscribe button styling in specific views (FreeTubeApp#4451) Translated using Weblate (Lithuanian) Bump electron from 27.1.3 to 28.0.0 (FreeTubeApp#4442) Fix pr-labeler.yml (FreeTubeApp#4449) Translated using Weblate (Estonian)
Hide playlists in channel search results if "hide channel playlist" preference selected.
Pull Request Type
Related issue
closes #4453
Description
This PR hides playlists in channel search results if the "hide channel playlists" preference is selected.
Screenshots
Before:
After:
Testing
I tested it by searching for "playlist" in the channel page, and observing playlist search results when the "hide channel preference" was not selected. I think selected this preference and performed the same search. No playlist results were displayed.
Desktop
Additional context
This project is great! It makes a big difference to my son.