Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix caption sorting & label #4513

Merged
merged 2 commits into from
Jan 6, 2024
Merged

Fix caption sorting & label #4513

merged 2 commits into from
Jan 6, 2024

Conversation

kommunarr
Copy link
Collaborator

@kommunarr kommunarr commented Jan 2, 2024 •
edited
Loading

Fix caption sorting & label

Pull Request Type

  • Bugfix

Related issue

#4450 (comment)

Description

  1. Fixes Locale Name label presenting improperly as "locale name"
  2. Fixes auto-translated captions coming first for non-English locales (over non-auto captions)

Screenshots

Before After
Screenshot_20240102_170913 Screenshot_20240102_170835
Before After
Screenshot_20240102_171113 Screenshot_20240102_171059

Testing

  1. Change locale to German and navigate to this video. See that german is top result. See that the second option shows deutsch instead of locale name.

Desktop

  • OS: OpenSUSE Tumbleweed
  • OS Version: 2023xxxx
  • FreeTube version: 0.19.1

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 2, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) January 2, 2024 23:14
@kommunarr kommunarr requested a review from absidue January 3, 2024 00:47
@FreeTubeBot FreeTubeBot merged commit baa7b01 into FreeTubeApp:development Jan 6, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@absidue absidue absidue approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kommunarr @PikachuEXE @absidue @efb4f5ff-1298-471a-8973-3d47447115dc @FreeTubeBot