Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hide sharing actions also hiding hide/show channel #5110

Merged
merged 1 commit into from
May 14, 2024
Merged

Fix hide sharing actions also hiding hide/show channel #5110

merged 1 commit into from
May 14, 2024

Conversation

absidue
Copy link
Member

@absidue absidue commented May 13, 2024

Fix hide sharing actions also hiding hide/unhide channel

Pull Request Type

  • Bugfix

Related issue

closes #5109

Description

The Hide Sharing Actions setting currently also hides the Hide/Show Channel option in the 3 dots drop down on videos in lists. This pull request corrects that.

Screenshots

Before:
before

After:
after

Testing

  1. Turn on the Hide Sharing Actions in the distraction free settings
  2. Click the 3 dots button on a video in a list
  3. The Hide Channel or Show Channel option should still be visible.

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 0.20.0

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) May 13, 2024 19:04
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label May 13, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc approved these changes May 14, 2024
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Unrelated bug found:

I was able to add a channel multiple times to the blocklist by clicking on Hide Channel

VirtualBoxVM_fGTXbJPVBI.mp4

@FreeTubeBot FreeTubeBot merged commit 2fcd5c9 into FreeTubeApp:development May 14, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label May 14, 2024
@absidue absidue deleted the fix-hide-sharing-actions branch May 14, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kommunarr kommunarr kommunarr approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@ChunkyProgrammer ChunkyProgrammer Awaiting requested review from ChunkyProgrammer

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Hide Sharing Actions removes abillity to Hide a Channel
5 participants
@absidue @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @kommunarr @FreeTubeBot