Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use auto scrollbar size for all scrollbars except the side nav #5172

Merged

Conversation

kommunarr
Copy link
Collaborator

@kommunarr kommunarr commented May 25, 2024

Use auto scrollbar size for all scrollbars except the side nav

Pull Request Type

  • Feature Implementation

Related issue

#321, #346, #3057 (sets higher sensible default addressing the usability issues referenced)

Description

Uses default platform scrollbar size for all scrollbars except the side nav (where it's too much of a headache to address at this time). Also implements a behavior to have the scrollbar size increase on hover (which includes the side nav). Hopefully should help most users having issues with the scrollbar being too small. If people's needs still aren't adequately addressed by this come v0.21, we can go forward with adding a new setting as requested in #3057.

Screenshots

Without hover:

Screenshot_20240525_091527

With hover (in this case, the rightmost scrollbar):

Screenshot_20240525_091557

With hover (in this case, the side nav scrollbar):

Screenshot_20240525_091703

Testing

  • Look at the side nav scrollbar and try hovering over it
  • Look at any other scrollbar and try hovering over it

Desktop

  • OS: OpenSUSE
  • OS Version: TW

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label May 25, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) May 25, 2024 13:48
@absidue
Copy link
Member

absidue commented May 25, 2024

As the scrollbars are really wide now, maybe we could keep them at 6px and expand them to auto when the cursor is over the ::-webkit-scrollbar and ::-webkit-scrollbar-thumb? That would also make it possible to add it to the sidebar, as it would only expand when you are using the scrollbar.

@kommunarr
Copy link
Collaborator Author

kommunarr commented May 25, 2024

Updated with your suggestion and some slight modification:

Without hover:

Screenshot_20240525_091527

With hover (in this case, the rightmost scrollbar):

Screenshot_20240525_091557

With hover (in this case, the side nav scrollbar):

Screenshot_20240525_091703

@FreeTubeBot FreeTubeBot merged commit bf3304d into FreeTubeApp:development Jun 9, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants