Larger search/URL bar #5348
Merged
Larger search/URL bar #5348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's now `1fr 1.5fr .5fr` for the grid. Still have to add `flex-shrink` to `.side` in case logo is hidden.
github-actions
bot
added
the
PR: waiting for review
3 tasks
kommunarr
reviewed
Jun 29, 2024
auto-merge was automatically disabled
June 29, 2024 19:32
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
June 29, 2024 19:35
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
June 30, 2024 00:58
Head branch was pushed to by a user without write access
kommunarr
approved these changes
Jun 30, 2024
kommunarr
requested review from
PikachuEXE,
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
MarmadileManteater
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jun 30, 2024
PikachuEXE
approved these changes
Jun 30, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jul 7, 2024
* shaka-migration: (87 commits) Bump mpd_version from 5 to 7 Move shaka-player CSS import into the Vue file Add chapter markers Fix i18n import in custom player components Update shaka-player to version 4.10.0 Translated using Weblate (French) Bump marked from 13.0.0 to 13.0.1 (FreeTubeApp#5357) Bump electron-context-menu from 4.0.0 to 4.0.1 (FreeTubeApp#5356) Bump electron from 31.0.2 to 31.1.0 (FreeTubeApp#5355) Bump postcss from 8.4.38 to 8.4.39 in the stylelint group (FreeTubeApp#5354) Bump eslint-plugin-promise from 6.2.0 to 6.4.0 in the eslint group (FreeTubeApp#5353) Larger search/URL bar (FreeTubeApp#5348) Translated using Weblate (Hungarian) Translated using Weblate (Hungarian) Translated using Weblate (English (United Kingdom)) Translated using Weblate (Italian) Translated using Weblate (Spanish (Mexico)) Translated using Weblate (French) Translated using Weblate (German) Translated using Weblate (Turkish) ... # Conflicts: # src/renderer/store/modules/index.js
|
Looks like this pull request was only designed with wide window sizes in mind which results in this bug: #5540 @4yman-0 Please create a follow up pull request that only uses the changes from this pull request on wide window sizes, to fix that bug. Would be nice if we didn't have to revert your pull request to fix the bug. |
|
I don't think that's quite it, because even on wide window sizes it appears off-center, because it's centered using grid across the whole width of the top bar (and thus relative to the viewport, rather than the content area as would feel more natural (#5540)). |
efb4f5ff-1298-471a-8973-3d47447115dc
added a commit
that referenced
this pull request
Sep 30, 2024
This reverts commit 38edc70.
1 task
FreeTubeBot
pushed a commit
that referenced
this pull request
Oct 1, 2024
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Oct 3, 2024
* development: (49 commits) Translated using Weblate (Japanese) Translated using Weblate (French) Fix long comments overflowing and breaking the layout (FreeTubeApp#5774) Cleanup unused code in the store (FreeTubeApp#5776) Revert "Larger search/URL bar (FreeTubeApp#5348)" (FreeTubeApp#5773) Fix loading from search cache failing when no features are selected (FreeTubeApp#5775) Bump lefthook from 1.7.15 to 1.7.17 (FreeTubeApp#5768) Bump webpack from 5.94.0 to 5.95.0 (FreeTubeApp#5770) Bump sass from 1.79.3 to 1.79.4 (FreeTubeApp#5771) Translated using Weblate (Chinese (Traditional Han script)) Change the Proxy Videos Through Invidious setting to only apply when using the Invidious API (FreeTubeApp#5758) Support copying post links from the context menu (FreeTubeApp#5760) Local API: Fix error when a community post has no likes (FreeTubeApp#5759) Translated using Weblate (English (United Kingdom)) Translated using Weblate (Dutch) Translated using Weblate (Swedish) Do not overwrite cache entries when hitting RSS ratelimits (FreeTubeApp#5756) Translated using Weblate (Czech) Translated using Weblate (Hungarian) Translated using Weblate (Hungarian) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Larger search/URL bar #5341
Pull Request Type
Related issue
closes #5341
Description
modify
top-navSCSS so that the grid gives more space to search bar. This PR also increases its max width.Screenshots
before:
after:
Desktop
Additional context
I also want to add
flex-shrinkfor first item for "hide FreeTube logo" because SPACE WASTE.