-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use auto-generated playlists for the videos tab on artist topic channels #5661
Use auto-generated playlists for the videos tab on artist topic channels #5661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also test a normal channel like https://www.youtube.com/@YouTube just to make sure I didn't break anything.
Shorts tab doesnt display any videos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shorts being empty is unrelated to this PR
* development: (24 commits) Add ability to see comment replies of community posts through invidious (FreeTubeApp#5589) Bump electron-builder from 24.13.3 to 25.0.5 (FreeTubeApp#5674) Change Sponsorblock Default Category Colors (FreeTubeApp#5686) Proxy live streams when "Proxy Videos Through Invidious" is enabled (FreeTubeApp#5649) Translated using Weblate (Belarusian) Translated using Weblate (Hebrew) Fix saving Invidious thumbnail URLs for subscriptions (FreeTubeApp#5662) Bump peter-evans/create-pull-request from 6 to 7 (FreeTubeApp#5676) Bump webpack-dev-server from 5.0.4 to 5.1.0 (FreeTubeApp#5672) Use auto-generated playlists for the videos tab on artist topic channels (FreeTubeApp#5661) Rewrite locale file updating to be more Vue 3 friendly (FreeTubeApp#5660) Bump sass from 1.77.8 to 1.78.0 (FreeTubeApp#5673) Bump electron from 32.0.1 to 32.0.2 (FreeTubeApp#5671) Bump marked from 14.1.0 to 14.1.2 (FreeTubeApp#5670) Bump postcss from 8.4.44 to 8.4.45 in the stylelint group (FreeTubeApp#5669) Bump the eslint group with 2 updates (FreeTubeApp#5668) Cleanup a few vue-i18n usages (FreeTubeApp#5663) Use nextTick instead of setTimeout to wait until Vue has rendered changes (FreeTubeApp#5664) Translated using Weblate (Estonian) Translated using Weblate (Belarusian) ... # Conflicts: # src/renderer/components/ft-community-post/ft-community-post.js # src/renderer/helpers/api/local.js
Use auto-generated playlists for the videos tab on artist topic channels
Pull Request Type
Related issue
#5282
as well as various users in the Matrix chat
Description
Various users have asked about being able to see the videos on artist topic channels and each time I've had to point out that YouTube doesn't show them on the channels, so we can't either.
However I have since discovered that despite YouTube not displaying a videos tab on those artist topic channels, the auto-generated uploads playlists still exist, so we are able to show the videos tab and populate it with content from those playlists. YouTube doesn't have auto-generated playlists sorted by oldest, so we can only offer sorting by newest and popularity on those channels.
We already supported showing content from those channels on the subscriptions page if you used RSS as we already use those playlists for RSS, but without RSS the subscriptions page acted like the channels didn't have any uploads as the videos tab is missing, this pull request also adds the playlist logic to the subscriptions page.
Please note that Invidious doesn't support those artist topic channels and returns a HTTP 500 error when you visit one of them, so this pull request is just for the local API.
Screenshots
Testing
Adele: https://www.youtube.com/channel/UCRw0x9_EfawqmgDI2IgQLLg
Empty Adele clone: https://www.youtube.com/channel/UCARQGyrd8OaaxkLsPZrOB9g
Test those two channels with the local API on both the channel and subscriptions pages (Invidious returns HTTP 500 for artist topic channels)
Please also test a normal channel like https://www.youtube.com/@YouTube just to make sure I didn't break anything.
Desktop