Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subscriptions CSV import shortening channel names #5793

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Fix subscriptions CSV import shortening channel names #5793

merged 1 commit into from
Oct 5, 2024

Conversation

absidue
Copy link
Member

@absidue absidue commented Oct 4, 2024

Fix subscriptions CSV import shortening channel names

Pull Request Type

  • Bugfix

Description

This pull request fixes the subscriptions CSV import removing the last character from channel names when they are quoted. We probably never noticed this problem before as we used to make API requests during the import, so the name was replaced with the one from the API response.

Noticed this while working on another pull request.

Screenshots

youtub

Testing

  1. Download this file (remove the .txt file extension) and import it into FreeTube: subscriptions.csv.txt
  2. Check in the side bar that the YouTube channel (the only one in the file) is actually called YouTube

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 43c6262

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 4, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 4, 2024 16:34
PikachuEXE
PikachuEXE approved these changes Oct 5, 2024
View reviewed changes
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here have a bath tub guard
image

@FreeTubeBot FreeTubeBot merged commit 9150fa2 into FreeTubeApp:development Oct 5, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 5, 2024
@absidue absidue deleted the csv-channel-name branch October 5, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@kommunarr kommunarr Awaiting requested review from kommunarr

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@absidue @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @FreeTubeBot